Skip to content

Fix FSF address in headers and license file #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2022

Conversation

mattiaverga
Copy link
Contributor

Some headers and the liblilxml license file still report the outdated Free Software Foundation address.

@brandon-rhodes
Copy link
Contributor

According to the Fedora project, the license itself can't be changed:

https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address

Could you remove the LICENSE file from the pull request so we avoid rewriting a license that isn't ours to rewrite? Thanks! (Or, am I mis-applying the Fedora rule?)

@mattiaverga
Copy link
Contributor Author

mmm I assume we can overwrite the LICENSE file with an updated copy from FSF, I don't think it changes anything but the address.
But I'll ask on Fedora legal mailing list for clarification about that.

@mattiaverga
Copy link
Contributor Author

So, it doesn't seem important to update the FSF address, after all... https://lists.fedoraproject.org/archives/list/legal@lists.fedoraproject.org/thread/4N3NO5NJJ6ND3T2ZDZ2A6LF4HRBOTWVR/

I'll update the PR to only change the FSF address on xephem sources, leaving the liblilxml sources untouched.

@brandon-rhodes brandon-rhodes merged commit b7bfc6e into XEphem:main Sep 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants