Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IP-Secure Routing support #1045

Merged
merged 14 commits into from Oct 7, 2022
Merged

Add IP-Secure Routing support #1045

merged 14 commits into from Oct 7, 2022

Conversation

farmio
Copy link
Member

@farmio farmio commented Oct 3, 2022

Description

Add IP-Secure Routing support

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • The documentation has been adjusted accordingly
  • Tests have been added that prove the fix is effective or that the feature works
  • The changes are documented in the changelog (docs/changelog.md)

@farmio farmio added the 🚀 enhancement enhancements label Oct 3, 2022
@farmio farmio requested a review from marvin-w October 3, 2022 21:57
@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Merging #1045 (5fa7f8b) into main (58348de) will decrease coverage by 0.06%.
The diff coverage is 94.52%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1045      +/-   ##
==========================================
- Coverage   96.42%   96.36%   -0.07%     
==========================================
  Files         138      138              
  Lines        8363     8577     +214     
==========================================
+ Hits         8064     8265     +201     
- Misses        299      312      +13     
Impacted Files Coverage Δ
xknx/io/knxip_interface.py 85.16% <86.95%> (-0.03%) ⬇️
xknx/io/routing.py 90.55% <89.47%> (+1.07%) ⬆️
xknx/io/ip_secure.py 95.22% <95.22%> (ø)
xknx/io/connection.py 97.29% <100.00%> (+0.23%) ⬆️
xknx/io/tunnel.py 88.72% <100.00%> (ø)
xknx/secure/keyring.py 99.11% <100.00%> (+<0.01%) ⬆️

Copy link
Member

@marvin-w marvin-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@farmio
Copy link
Member Author

farmio commented Oct 4, 2022

Cool! I'll try to add some tests before merging.

@farmio farmio merged commit 42b45b8 into main Oct 7, 2022
@farmio farmio deleted the secure_routing branch October 7, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants