-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/solana tbtc canonical #298
Conversation
}) | ||
); | ||
return; | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this else
should be redundant if you're return
ing above, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, but due to the nature of this code, we want to interrupt the execution here, to avoid checking the other ifs like the
if (isTerraChain(sourceChain) && sourceAsset) {
* create associated account works * fix base58 address convertion for Solana gateway program * pull accounts from custodia account * implement send< btct * update tokenBridgeWrappedAsset account derivation to send tbtc to solana * setup sender arguments * [skip ci] - run prettier * remove unecesary console.log * remove unecesary console.log * fix parameters to send back to L1 * create ata for the redeem process * handle case for sending from non L1 to a non L1 evm chain * cosmetic changes * initialize associate token account if not exist * call the gateway if the asset is tBtc v2 * [skip ci] - run prettier * add mainnet address * [skip ci] - bump version * code review observation
No description provided.