Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Update xoopsload.php #668
This PR and #667 really should be combined. Not a big problem, just neither stands alone.
What we really need to go with this is a reference Bootstrap4 based theme for XOOPS. Both of the currently included form renderers have such a reference, 'default' for legacy and 'xBootstrap' for bootstrap3. This makes it practical to test each renderer against XOOPS internals and a range of common modules. Without that reference theme, both #667 and #668 won't go.
I know there are several v4 themes, including an xBootstrap version that @mambax7 has been working on. That might be a possibility, or maybe there is something new and innovative? We need to decide what this new theme will be.
In the meantime, the renderer can still be used without core changes. One of the design goals of the form renderer concept is that it can be included in the theme itself, and can be customized as needed. There are a lot more css/js frameworks than just 2 bootstrap variations, and most of them will never get a pre-built renderer.
I do think there is great value in adding Bootstrap 4 support. We just need to decide on the reference implementation.
Also note, 2.5.10 is well into its release cycle. There are already modules waiting for it. The changes discussed here will not be merged until the current release cycle is completed. The target would be 2.5.11.