Permalink
Tag: XQuartz-2.7.9
Commits on Dec 28, 2015
  1. fb: Revert fb changes that broke XQuartz

    jeremyhu committed May 31, 2014
        http://bugs.freedesktop.org/show_bug.cgi?id=26124
    
    Revert "Use new pixman_glyph_cache_t API that will be in pixman 0.28.0"
    Revert "fb: Fix origin of source picture in fbGlyphs"
    Revert "fb: Publish fbGlyphs and fbUnrealizeGlyph"
    
    This reverts commit 9cbcb5b.
    This reverts commit 983e303.
    This reverts commit 3c2c59e.
  2. fb: Revert fb changes that broke XQuartz

    jeremyhu committed Feb 13, 2010
    http://bugs.freedesktop.org/show_bug.cgi?id=26124
    
    Revert "Fix source pictures getting random transforms after 2d6a8f6."
    Revert "fb: Adjust transform or composite coordinates for pixman operations"
    
    http://bugs.freedesktop.org/26124
    
    This reverts commit a72c65e.
    This reverts commit a6bd5d2.
    
    Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
  3. Use old miTrapezoids and miTriangles routines

    jeremyhu committed Nov 2, 2013
    Reverts commits:
        788ccb9
        566f193
    
    http://xquartz.macosforge.org/trac/ticket/525
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
  4. sdksyms.sh: Use CPPFLAGS, not CFLAGS

    jeremyhu committed Jan 13, 2012
    CFLAGS can include flags which are not useful to the preprocessor
    or can even cause it to fail.  This fixes a build issue on darwin
    when building for more than one architecture.
    
    Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
    Reviewed-by: Keith Packard <keithp@keithp.com>
  5. XQuartz: Change our domain to xquartz.org

    jeremyhu committed Dec 28, 2015
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    (cherry picked from commit 7f3ee74)
Commits on Oct 29, 2015
  1. xfree86: Use same inb/outb asm code for i386 amd64 and ia64

    nwnk authored and jeremyhu committed Oct 21, 2015
    This matches the GCCUSESGAS path from the old monolith build (where that
    macro was actually set), and fixes the build on modern OSX.
    
    Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    Signed-off-by: Adam Jackson <ajax@redhat.com>
    (cherry picked from commit 47b00fa)
Commits on Oct 28, 2015
  1. xserver 1.17.4

    nwnk committed Oct 28, 2015
Commits on Oct 27, 2015
  1. os: make sure the clientsWritable fd_set is initialized before use

    Martin Peres authored and nwnk committed Jul 20, 2015
    In WaitForSomething(), the fd_set clientsWritable may be used
    unitialized when the boolean AnyClientsWriteBlocked is set in the
    WakeupHandler(). This leads to a crash in FlushAllOutput() after
    x11proto's commit 2c94cdb453bc641246cc8b9a876da9799bee1ce7.
    
    The problem did not manifest before because both the XFD_SIZE and the
    maximum number of clients were set to 256. As the connectionTranslation
    table was initalized for the 256 clients to 0, the test on the index not
    being 0 was aborting before dereferencing the client #0.
    
    As of commit 2c94cdb453bc641246cc8b9a876da9799bee1ce7 in x11proto, the
    XFD_SIZE got bumped to 512. This lead the OutputPending fd_set to have
    any fd above 256 to be uninitialized which in turns lead to reading an
    index after the end of the ConnectionTranslation table. This index would
    then be used to find the client corresponding to the fd marked as
    pending writes and would also result to an out-of-bound access which
    would usually be the fatal one.
    
    Fix this by zeroing the clientsWritable fd_set at the beginning of
    WaitForSomething(). In this case, the bottom part of the loop, which
    would indirectly call FlushAllOutput, will not do any work but the next
    call to select will result in the execution of the right codepath. This
    is exactly what we want because we need to know the writable clients
    before handling them. In the end, it also makes sure that the fds above
    MaxClient are initialized, preventing the crash in FlushAllOutput().
    
    Thanks to everyone involved in tracking this one down!
    
    Reported-by: Karol Herbst <freedesktop@karolherbst.de>
    Reported-by: Tobias Klausmann <tobias.klausmann@mni.thm.de>
    Signed-off-by: Martin Peres <martin.peres@linux.intel.com>
    Tested-by: Tobias Klausmann <tobias.klausmann@mni.thm.de>
    Tested-by: Martin Peres <martin.peres@linux.intel.com>
    Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=91316
    Cc: Ilia Mirkin  <imirkin@alum.mit.edu>
    Cc: Olivier Fourdan <ofourdan@redhat.com
    Cc: Adam Jackson <ajax@redhat.com>
    Cc: Alan Coopersmith <alan.coopersmith@oracle.com
    Cc: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
  2. Xext: fix build with --disable-xace

    Julien Cristau authored and nwnk committed Oct 27, 2015
    Regression from 990cf5b
    
    Signed-off-by: Julien Cristau <jcristau@debian.org>
    Cc: Andrew Eikum <aeikum@codeweavers.com>
    Cc: Peter Hutterer <peter.hutterer@who-t.net>
    Signed-off-by: Andrew Eikum <aeikum@codeweavers.com>
    (cherry picked from commit 524844c)
  3. DRI2: Sync radeonsi_pci_ids.h from Mesa

    Michel Dänzer authored and nwnk committed Oct 27, 2015
    Fixes DRI2 client driver name mapping for newer AMD GPUs with the
    modesetting driver, allowing the DRI2 extension to initialize.
    
    Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
    (cherry picked from commit ac2f27f)
Commits on Oct 26, 2015
  1. xserver 1.17.3

    nwnk committed Oct 26, 2015
    Signed-off-by: Adam Jackson <ajax@redhat.com>
  2. present: Fix missed notify MSC computation

    ickle authored and nwnk committed Feb 16, 2015
    Only treat divisor==0 as async to immediately report the actual vblank.
    If the user species a non-zero divisor, we should compute the missed
    vblank properly or else we report too early.
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Mario Kleiner <mario.kleiner.de@gmail.com>
    (cherry picked from commit 413cb2f)
  3. linux: Do not call FatalError from xf86CloseConsole

    jwrdegoede authored and nwnk committed Oct 21, 2015
    FatalError ends up calling xf86CloseConsole itself, so calling FatalError
    from within xf86CloseConsole is not a good idea.
    
    Make switch_to log errors using xf86Msg(X_WARNING, ...) and return success
    (or failure).
    
    This makes switch_to match the other error checking done in xf86CloseConsole
    which all logs warnings and continues.
    
    Add checking of the return value in xf86OpenConsole and call
    FatalError there when switch_to fails, to preserve the error-handling
    behavior of xf86OpenConsole.
    
    BugLink: https://bugzilla.redhat.com/show_bug.cgi?id=1269210
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Hans de Goede <hdegoede@redhat.com>
    (cherry picked from commit 2092f12)
  4. fonts: Continue when font calls return Suspended more than once

    keith-packard authored and nwnk committed Sep 21, 2015
    Patch 3ab6cd3 fixed Xinerama
    interactions with font servers by not putting clients to sleep
    multiple times. However, it introduced additional changes dealing with
    libXfont routine returning Suspended more than once for the same
    request. This additional change was to abandon processing of the
    current request and free the closure data by jumping to
    'xinerama_sleep' in each of the functions.
    
    Font library functions shouldn't return Suspended more than once,
    except for ListFontsWithInfo, which produces multiple replies, and
    thus ends up returning Suspended many times during processing.
    
    With the jump to xinerama_sleep occurring after the first reply was
    processed, the closure for the request was freed and future calls into
    the ListFontsWithInfo callback resulted in dereferencing freed
    memory.
    
    This patch removes the added branches, reverting the code to its
    previous behaviour, which permitted multiple Suspended returns and
    simply waited for the client to be signaled again so that the callback
    could continue processing the request.
    
    Signed-off-by: Keith Packard <keithp@keithp.com>
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    (cherry picked from commit f9a04d1)
  5. glx: Fix header length error checking in __glXDisp_RenderLarge

    jeremyhu authored and nwnk committed Oct 19, 2015
    glxcmds.c:2206:46: warning: comparison of unsigned expression < 0 is always false [-Wtautological-compare,Semantic Issue]
            if ((cmdlen = safe_pad(hdr->length)) < 0)
                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~
    
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    (cherry picked from commit e098757)
  6. xdmcp: Declare XdmcpFatal _X_NORETURN

    jeremyhu authored and nwnk committed Oct 14, 2015
    xdmcp.c:1404:1: warning: function 'XdmcpFatal' could be declared with attribute 'noreturn'
    [-Wmissing-noreturn,Semantic Issue]
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 9a2a05a)
  7. xdmauth: Correct miscall of abs() to instrad call labs()

    jeremyhu authored and nwnk committed Oct 14, 2015
    xdmauth.c:230:13: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of
    type
    'int'
          which may cause truncation of value [-Wabsolute-value,Semantic Issue]
            if (abs(now - client->time) > TwentyFiveMinutes) {
                ^
    xdmauth.c:230:13: note: use function 'labs' instead [Semantic Issue]
            if (abs(now - client->time) > TwentyFiveMinutes) {
                ^~~
                labs
    xdmauth.c:302:9: warning: absolute value function 'abs' given an argument of type 'long' but has parameter of type
    'int' which
          may cause truncation of value [-Wabsolute-value,Semantic Issue]
        if (abs(client->time - now) > TwentyMinutes) {
            ^
    xdmauth.c:302:9: note: use function 'labs' instead [Semantic Issue]
        if (abs(client->time - now) > TwentyMinutes) {
            ^~~
            labs
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 85eb90e)
  8. randr: Correct a miscall of abs() to instead call fabs()

    jeremyhu authored and nwnk committed Oct 14, 2015
    rrtransform.c:124:22: warning: using integer absolute value function 'abs' when
          argument is of floating point type [-Wabsolute-value,Semantic Issue]
                if ((v = abs(f_transform->m[j][i])) > max)
                         ^
    rrtransform.c:124:22: note: use function 'fabs' instead [Semantic Issue]
                if ((v = abs(f_transform->m[j][i])) > max)
                         ^~~
                         fabs
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 9f0fcd1)
  9. mi: Correct a miscall of abs() to instead call fabs()

    jeremyhu authored and nwnk committed Oct 14, 2015
    miarc.c:1714:9: warning: using integer absolute value function
    'abs' when
          argument is of floating point type [-Wabsolute-value,Semantic Issue]
        if (abs(parc->angle2) >= 360.0)
            ^
    miarc.c:1714:9: note: use function 'fabs' instead [Semantic Issue]
        if (abs(parc->angle2) >= 360.0)
            ^~~
            fabs
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 610dd8a)
  10. render: Propagate allocation failure from createSourcePicture()

    ickle authored and nwnk committed Dec 14, 2011
    All the callers were already checking for failure, except that
    createSourcePicture() itself was failing to check whether it
    successfully allocated the Picture.
    
    [ajax: Rebase, fix line wrap of preceding line]
    
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
    (cherry picked from commit 211d4c2)
  11. Fix alphamap interactions with wfb

    Arcady Goldmints-Orlov authored and nwnk committed Oct 4, 2012
    Set a destructor function on pixman images and call fbFinishAccess()
    from there, rather than directly from free_pixman_pict(). This ensures
    that fbFinishAccess() gets called even if pixman still has a reference
    to the image after free_pixman_pict(), as is the case for alphamaps.
    
    [ajax: Squash an unused variable warning in the non-wfb build]
    
    Reviewed-by: Aaron Plattner <aplattner@nvidia.com>
    Signed-off-by: Arcady Goldmints-Orlov <arcadyg@nvidia.com>
    Reviewed-by: Søren Sandmann <ssp@redhat.com>
    (cherry picked from commit fbac451)
  12. dri2: better checks for integer overflow in GetBuffers*

    alanc authored and nwnk committed Sep 22, 2015
    Check for integer overflow before using stuff->count in a multiplication,
    to avoid compiler optimizing out due to undefined behaviour, but only
    after we've checked to make sure stuff->count is in the range of the
    request we're parsing.
    
    Reported-by: jes@posteo.de
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 6ca496b)
  13. Xext/xselinux: Warning fixes

    keith-packard authored and nwnk committed Sep 21, 2015
    There's a 'const char *' adventure here that I'm mostly ignoring; some
    client information gets const poisoned. Worked around by adding a
    couple of casts. Ick.
    
    Added an _X_ATTRIBUTE_PRINTF to SELinuxLog.
    
    Ignore a couple of unused return values.
    
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Keith Packard <keithp@keithp.com>
    (cherry picked from commit 9af111f)
  14. x86emu: Fix some set-but-not-used warnings.

    anholt authored and nwnk committed May 5, 2014
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Eric Anholt <eric@anholt.net>
    (cherry picked from commit e6f8a03)
  15. render: Fix leak of filter params

    ickle authored and nwnk committed Jan 27, 2014
    ==11097== 2,048 (+1,640) bytes in 32 (+26) blocks are definitely lost in loss record 1,570 of 1,719
    ==11097==    at 0x4C2A2DB: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
    ==11097==    by 0x225EF3: SetPicturePictFilter (filter.c:339)
    ==11097==    by 0x22DF4F: ProcRenderSetPictureFilter (render.c:1773)
    ==11097==    by 0x15D25D: Dispatch (dispatch.c:432)
    ==11097==    by 0x14C7B9: main (main.c:298)
    
    [ajax: Fixed whitespace]
    
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
    (cherry picked from commit c7f84c8)
  16. xfree86: Fix the 1792x1344-75 EST III mode

    vsyrjala authored and nwnk committed Oct 14, 2013
    The correct refresh rate for this mode is 75, not 85.
    
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
    (cherry picked from commit 98e1709)
  17. randr: Allow RRSelectInput for ProviderChange and ResourceChange events

    Michal Srb authored and nwnk committed Oct 7, 2013
    [ajax: To be clear, we already have code to emit these events, and it
     looks like it works, but to get them you'd have had to also ask for one
     of the other notify types.  This makes it possible to listen for e.g.
     ProviderChange alone.]
    
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Michal Srb <msrb@suse.com>
    (cherry picked from commit 91c7acf)
  18. exa: initialise mask_off_x and mask_off_y

    airlied authored and nwnk committed Oct 20, 2011
    These get used at the end of the function in a calculation,
    even though the result isn't used its not pretty.
    
    Pointed out by coverity.
    
    Signed-off-by: Dave Airlie <airlied@redhat.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 4c7cefe)
  19. render: Allow single-stop gradients

    ranma42 authored and nwnk committed Jul 27, 2011
    The Render specification allows single-stop gradients and pixman 0.22
    (X server requires >= 0.27.2 now) can rasterize them correctly.
    
    [ajax: update commit message]
    
    Signed-off-by: Andrea Canciani <ranma42@gmail.com>
    Reviewed-by: Soren Sandmann <ssp@redhat.com>
    (cherry picked from commit 7ed0c39)
  20. man: Fix case for MIT-unspecified.

    Cyril Brulebois authored and nwnk committed Jun 5, 2011
    include/site.h says that COMPILEDDISPLAYCLASS is MIT-unspecified, rather
    than MIT-Unspecified. Fix the manpage accordingly.
    
    Signed-off-by: Cyril Brulebois <kibi@debian.org>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 4803f71)
  21. protocol.txt: Add MIT-SHM 1.2 requests

    alanc authored and nwnk committed Sep 23, 2015
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit a31bbc4)
  22. protocol.txt: Add DRI3 1.0 requests

    alanc authored and nwnk committed Sep 23, 2015
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 424ba5d)
  23. protocol.txt: Add Present 1.0 requests

    alanc authored and nwnk committed Sep 23, 2015
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 7e6b7c7)
  24. protocol.txt: Remove extensions that died before Xorg was born

    alanc authored and nwnk committed Sep 23, 2015
    Adobe-DPS-Extension, DEC-XTRAP, X3D-PEX, XIE
    
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    (cherry picked from commit 1ea8fb9)