From 5b20fe573eca5af9ab72fa497b11640cf8591b34 Mon Sep 17 00:00:00 2001 From: Alan Cohen Date: Mon, 21 Mar 2016 10:18:19 -0700 Subject: [PATCH] FIX: Filtering source_amount pathfind correctly Bug: ```js api.connect().then(() => { const pathfind = { source: { address: USDCold, amount: { currency: 'USD', value: '1.00' // <<<< Rippled response has "1" not "1.00" } }, destination: { address: EURCold, amount: {currency: 'EUR'} } }; return api.getPaths(pathfind).then(paths => { console.log('PATHS: \n', JSON.stringify(paths, null, 2)); }); }).catch(console.log); ``` --- src/ledger/pathfind.js | 2 +- test/fixtures/requests/getpaths/send-all.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/ledger/pathfind.js b/src/ledger/pathfind.js index 7b934707fd..43f6f1f094 100644 --- a/src/ledger/pathfind.js +++ b/src/ledger/pathfind.js @@ -93,7 +93,7 @@ function filterSourceFundsLowPaths(pathfind: PathFind, paths.alternatives = _.filter(paths.alternatives, alt => { return alt.source_amount && pathfind.source.amount && - alt.source_amount.value === pathfind.source.amount.value; + new BigNumber(alt.source_amount.value).eq(pathfind.source.amount.value); }); } return paths; diff --git a/test/fixtures/requests/getpaths/send-all.json b/test/fixtures/requests/getpaths/send-all.json index b6321e710b..d54ce3bdfa 100644 --- a/test/fixtures/requests/getpaths/send-all.json +++ b/test/fixtures/requests/getpaths/send-all.json @@ -3,7 +3,7 @@ "address": "r9cZA1mLK5R5Am25ArfXFmqgNwjZgnfk59", "amount": { "currency": "USD", - "value": "5" + "value": "5.00" } }, "destination": {