New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie not recognized, only TV #119

Closed
batfos opened this Issue Jun 18, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@batfos

batfos commented Jun 18, 2018

I just updated to the latest (2.0.0a2.dev18+g9b9d57c) and now movies (and anime series) not recognized, only TV. I checked in the trakt_cache file, there is no IMDb information except for TV shows. With the previous release it was working fine. I try renaming the files but still not working.

@XaF

This comment has been minimized.

Owner

XaF commented Jun 19, 2018

Hi,

Can you please provide a log file in debug mode?

Thanks!

@batfos

This comment has been minimized.

batfos commented Jun 19, 2018

Is it the right file?
log.txt

@XaF

This comment has been minimized.

Owner

XaF commented Jun 20, 2018

Thank you, this will help me fix the bug! I'll work on that as soon as I get a minute :)

@batfos

This comment has been minimized.

batfos commented Jun 20, 2018

Thank you!

@batfos batfos reopened this Jun 20, 2018

@ac96789

This comment has been minimized.

ac96789 commented Jun 20, 2018

Just a quick question @XaF , once you've applied the patch.. How do we update?

@XaF

This comment has been minimized.

Owner

XaF commented Jun 21, 2018

Once the patch will be applied, you can just install the new version of TraktForVLC over the previous one. It will automatically uninstall the previous one and install the new one. If there is any problem during that process, please report with all of the details so I can try and fix it :)

XaF added a commit that referenced this issue Jun 21, 2018

helper: commands: resolve: fix movie resolution
Commit f436460 introduced a
bug by converting the imdb id returned in the URL form by
imdbpie to the imdb id alone, and doing so for the
'parentTitle' of the media, which represents a series for
a TV episode, but does not exist for a movie. This commit
fixes that behavior by checking that the 'parentTitle'
exists before applying the conversion at its level.

Fixes #119

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>

@XaF XaF closed this in #121 Jun 21, 2018

XaF added a commit that referenced this issue Jun 21, 2018

helper: commands: resolve: fix movie resolution
Commit f436460 introduced a
bug by converting the imdb id returned in the URL form by
imdbpie to the imdb id alone, and doing so for the
'parentTitle' of the media, which represents a series for
a TV episode, but does not exist for a movie. This commit
fixes that behavior by checking that the 'parentTitle'
exists before applying the conversion at its level.

Fixes #119

Signed-off-by: Raphaël Beamonte <raphael.beamonte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment