fix: "DELETE ... FROM ... LIMIT 0, 1" will have syntax error

refering at http://stackoverflow.com/questions/7142097/mysql-delete-statement-with-limit#answer-7142118
XadillaX · Oct 21, 2016 · d2d69d3 · d2d69d3
1 parent 5c2b30c
commit d2d69d3
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/lib/adapters/mysql.js b/lib/adapters/mysql.js
@@ -602,9 +602,16 @@ class MySQLAdapter extends Adapter {
         }
 
         if(options.limit && options.limit.length) {
-            const limit = this.makeLimit(model, options.limit);
-            if(limit) {
-                sql += ` LIMIT ${limit}`;
+            const limit = options.limit;
+            if(limit.length=== 1) {
+                sql += ` LIMIT ${limit[0]}`;
+            } else if(limit[0] === 0) {
+                sql += ` LIMIT ${limit[1]}`;
+            } else {
+                throw new Error("Invalid limit in delete. Refer to " +
+                    "http://dev.mysql.com/doc/refman/5.7/en/delete.html#idm139816273062400, " +
+                    "https://www.techonthenet.com/mysql/delete_limit.php and " +
+                    "http://stackoverflow.com/questions/7142097/mysql-delete-statement-with-limit#answer-7142118");
             }
         }