Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve-findById #29

Merged
merged 4 commits into from Nov 24, 2015
Merged

improve-findById #29

merged 4 commits into from Nov 24, 2015

Conversation

@luicfer
Copy link
Collaborator

@luicfer luicfer commented Nov 18, 2015

No description provided.

return callback(new Error("You should pass a valid IDs object."));
}

if (this.cache) {
return cache.getData(this.toshihiko.database, this.name, id, function (err, data) {

This comment has been minimized.

@houndci-bot

houndci-bot Nov 18, 2015
Collaborator

'cache' is not defined.

return callback(null, yukari)
}
return self.where(id).findOne(callback, withJson);
})

This comment has been minimized.

@houndci-bot

houndci-bot Nov 18, 2015
Collaborator

Missing semicolon.

if (withJson) {
yukari = yukari.toJSON();
}
return callback(null, yukari)

This comment has been minimized.

@houndci-bot

houndci-bot Nov 18, 2015
Collaborator

Missing semicolon.

if (this.cache) {
return cache.getData(this.toshihiko.database, this.name, id, function (err, data) {
if (err) {
data = []

This comment has been minimized.

@houndci-bot

houndci-bot Nov 18, 2015
Collaborator

Missing semicolon.

@luicfer luicfer force-pushed the luicfer:feature/Improve-findById branch from 8115819 to 98fa569 Nov 18, 2015
@luicfer luicfer closed this Nov 18, 2015
@luicfer luicfer reopened this Nov 24, 2015
@luicfer luicfer force-pushed the luicfer:feature/Improve-findById branch from d619327 to b04d36b Nov 24, 2015
XadillaX added a commit that referenced this pull request Nov 24, 2015
@XadillaX XadillaX merged commit 2a55319 into XadillaX:develop Nov 24, 2015
3 checks passed
3 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.09%) to 86.41%
Details
hound 1 violation found.
@luicfer luicfer deleted the luicfer:feature/Improve-findById branch Nov 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants