Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix encoder::ffmpeg attempting to create itself again #1048

Merged
merged 1 commit into from May 14, 2023
Merged

Fix encoder::ffmpeg attempting to create itself again #1048

merged 1 commit into from May 14, 2023

Conversation

Xaymar
Copy link
Owner

@Xaymar Xaymar commented May 14, 2023

Explain the Pull Request

Not sure why I did it any other way before - there's no benefit to the previous design, only downsides.

Completion Checklist

  • This has been tested on the following platforms:
    • MacOS 10.15
    • MacOS 11
    • MacOS 12
    • Ubuntu 20.04
    • Ubuntu 22.04
    • Windows 10
    • Windows 11
  • The copyright headers and license files have been updated.
  • I will maintain this for the forseeable future, and have added myself to CODEOWNERS.

@Xaymar
code: Fix encoder::ffmpeg causing recursive mutex lock on Singleton
f8e3c3e 
Not sure why I did it any other way before - there's no benefit to the previous design, only downsides.
@Xaymar Xaymar marked this pull request as ready for review May 14, 2023 18:22
@Xaymar Xaymar merged commit a802b00 into root May 14, 2023
8 checks passed
@Xaymar Xaymar deleted the patch/fix-singleton-lock branch May 14, 2023 18:22
@Xaymar Xaymar added this to the FFmpeg Encoders (Component) milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
FFmpeg Encoders (Component)
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Xaymar