This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix too many ERR_BUSY logs problem when write throttling enabled #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hycdong
reviewed
Apr 16, 2019
| "recent.read.busy.count", | ||
| COUNTER_TYPE_VOLATILE_NUMBER, | ||
| "read busy count in the recent period"); | ||
| _counter_recent_write_busy_count.init_app_counter("eon.replica_stub", |
There was a problem hiding this comment.
是不是改成_counter_recent_write_throtting_count更合适
There was a problem hiding this comment.
throttling分为delay和reject，只有reject返回ERR_BUSY，并将该counter加1
There was a problem hiding this comment.
那是不是改成_counter_recent_write_reject_count更合适？总觉得busy有些笼统
There was a problem hiding this comment.
ERR_BUSY未必只有在throttling reject的时候才会返回。
这样看来，我还是加上counter_recent_read_busy_count吧。
There was a problem hiding this comment.
嗯，我刚刚看了下代码，rpc busy的时候会返回ERR_BUSY，那还是加上吧
| @@ -276,6 +276,14 @@ void replica_stub::install_perf_counters() | |||
| "recent.write.fail.count", | |||
| COUNTER_TYPE_VOLATILE_NUMBER, | |||
| "write fail count in the recent period"); | |||
| _counter_recent_read_busy_count.init_app_counter("eon.replica_stub", | |||
There was a problem hiding this comment.
现在对read应该没有限流吧，暂时可以不加这个counter吧
There was a problem hiding this comment.
ERR_BUSY未必只有在throttling reject的时候才会返回，所以还是加上counter_recent_read_busy_count。
hycdong
approved these changes
Apr 16, 2019
neverchanje
approved these changes
Apr 16, 2019
10 tasks
neverchanje
pushed a commit
that referenced
this pull request
May 30, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
apache/incubator-pegasus#319