Haptic feedback, button morph, dial slide, heads-up notification#4
Merged
Conversation
- Haptic feedback on play/stop (CONFIRM) and +/- (CLOCK_TICK) buttons, gated by existing hapticFeedbackEnabled setting - PlayButton morphs between circle (idle) and rounded square (running) with a crossfade between play and stop icons - Dial slides smoothly when minutes change via +/- — both idle and while the timer is running; countdown ticks snap - Notification shows as heads-up on start only (setOnlyAlertOnce), fresh channel at IMPORTANCE_HIGH with sound/vibration disabled - New -5 min action in the notification, placed before +5 - Reusable remainingMillisToDisplayMinutes helper in core:data fixes the "30 → 29 after one second" rounding bug in the notification and unifies the rounding logic with the on-dial time display Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CONFIRM) and +/- (CLOCK_TICK) now trigger haptic feedback, gated by the existinghapticFeedbackEnabledsettingFastOutSlowInEasing; play/stop icons crossfadeAnimatable, threshold-based snap/animate (δ<1 min → snap; dragging → snap)setOnlyAlertOnce), ported to a fresh channel (sleep_timer_v2,IMPORTANCE_HIGH, sound/vibration disabled). PrevioussetSilent(true)was suppressing heads-upremainingMillisToDisplayMinuteshelper incore:datafixes the "30 → 29 after one second" rounding bug in the notification and unifies the ceiling logic with the on-dial time display.TimerUiState.Runningnow carriesremainingMillisinstead of derivedremainingMinutes/remainingSecondsTest plan
hapticFeedbackEnabled=false🤖 Generated with Claude Code