Localize hardcoded UI strings#9
Merged
Merged
Conversation
Replace hardcoded English strings in TimeDisplay (minute/minutes/hour/ hours/hr · min), ActionRow content descriptions, and theme labels with string resources, and add German translations. Remove unused minutes_label entries. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimeDisplay(minute/minutes/hour/hours/hr · min) with string resources — this is what actually rendered asMINUTESin the UI; the existingminutes_labelresource was never referenced.+/-buttoncontentDescriptions (previously hardcoded"Minus"/"Plus").AppTheme.label: Stringto@StringRes labelRes: Intand translate theme names (Midnight/Ocean/Ember/Light/Basic → Mitternacht/Ozean/Glut/Hell/Einfach).minutes_labelentries from bothapp/andfeature/timer/string resources.Test plan
MINUTES/HOURS/HR · MIN, theme cards read Midnight/Ocean/Ember/Light/Basic.MINUTEN/STUNDEN/STD · MIN, theme cards read Mitternacht/Ozean/Glut/Hell/Einfach.🤖 Generated with Claude Code