Remove the Photobucket filter #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I might be wrong but isn't that the whole reason the filter was added in the first place? |
|
it was added because photobucket had decided to lock image hosting behind a paywall. search for "photobucket p500" and you'll see some examples |
Xkeeper0
approved these changes
Jan 2, 2019
Hopefully in the future we won't need this at all, or wit can be fixed to not completely destroy things (I see now that the regex is way too greedy, oops)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Photobucket images work fine now:
I should probably not embed an image that I don't have control over (and could be changed later) but anyway, it shows that Photobucket is not being awful anymore and there's no need for this filter anymore (I hope).