Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No digest icon in subject list #21

Open
slider84 opened this issue Oct 2, 2015 · 1 comment
Open

No digest icon in subject list #21

slider84 opened this issue Oct 2, 2015 · 1 comment
Projects

Comments

@slider84
Copy link

slider84 commented Oct 2, 2015

In latest mamba RC10
To see this issue just try to make a subject with the three states (locked, sticky and digest).
In the previous mamba rc10 that was the locked icon that was absent.
capture

@mambax7
Copy link
Contributor

mambax7 commented Oct 5, 2015

That's currently by design, i.e. the NewBB offers only two spots for icons, and the second icon is based on priority set this way in forum.php ( sticky -> digest -> regular):

           // topic_icon: priority: sticky -> digest -> regular

            if ($myrow['topic_haspoll']) {
                if ($myrow['topic_sticky']) {
                    $topic_icon = newbbDisplayImage('topic_sticky', _MD_TOPICSTICKY) . '<br />' . newbbDisplayImage('poll', _MD_TOPICHASPOLL);
                } else {
                    $topic_icon = newbbDisplayImage('poll', _MD_TOPICHASPOLL);
                }
            } elseif ($myrow['topic_sticky']) {
                $topic_icon = newbbDisplayImage('topic_sticky', _MD_TOPICSTICKY);
            } elseif (!empty($myrow['icon'])) {
                $topic_icon = '<img src="' . XOOPS_URL . '/images/subject/' . htmlspecialchars($myrow['icon']) . '" alt="" />';
            } else {
                $topic_icon = '<img src="' . XOOPS_URL . '/images/icons/no_posticon.gif" alt="" />';
            }

in order to change it, we would need to rewrite the module to add a column for third icon that would show the "digest" status, and this might take some time/testing. I've done a prototype, so it is doable, but I would have to go back and address other areas that will be impacted by this change, e.g.:

  • if it is not digest, do we show an empty cell in the column?
  • if we don't show empty cell, then we have to redo the whole template, because the text above it will shift to the right an become out of sync

At this moment, I am not sure I'll have the time to work on this, but if you can, I can guide you to where to make the initial changes...

mambax7 pushed a commit to mambax7/newbb that referenced this issue Feb 9, 2019
@mambax7 mambax7 added this to Needs triage in Bugs Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Bugs
  
Needs triage
Development

No branches or pull requests

2 participants