Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing import in xpra/codecs/webp/encode.pyx #1379

Closed
totaam opened this issue Dec 10, 2016 · 4 comments
Closed

Missing import in xpra/codecs/webp/encode.pyx #1379

totaam opened this issue Dec 10, 2016 · 4 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 10, 2016

Issue migrated from trac ticket # 1379

component: android | priority: major | resolution: fixed

2016-12-10 11:56:04: jonathan.underwood created the issue


xpra-1.0 fails to build, complaining about this:

Compiling xpra/net/ben
Error compiling Cython file:
------------------------------------------------------------
...
import os

from xpra.log import Logger
log = Logger("encoder", "webp")

from xpra.util envbool
              ^
------------------------------------------------------------

xpra/codecs/webp/encode.pyx:11:15: Expected 'import' or 'cimport'
code/cython_bencode.pyx because it changed.
Compiling xpra/net/vsock.pyx because it changed.

Patch attached (trivial).

@totaam
Copy link
Collaborator Author

totaam commented Dec 10, 2016

2016-12-10 11:56:23: jonathan.underwood uploaded file xpra-1.0-webp-encode-fix-import.patch (0.5 KiB)

@totaam
Copy link
Collaborator Author

totaam commented Dec 10, 2016

2016-12-10 12:02:18: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Dec 10, 2016

2016-12-10 12:02:18: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Dec 10, 2016

2016-12-10 12:02:18: antoine commented


Thanks, applied to v1.0.x in 14524.

Note: all the packages we build have had webp disabled and webp support has now been removed in trunk as of r14508, together with csc_opencl and csc_opencv.
That's because:

  • loading our own build of webp (since {x264,ffmpeg,libvpx,libwep}-xpra packages #613) was causing too many problems: conflicts with python pillow loading the system one, performance differences between different versions and platforms, etc
  • opencl is buggy (see AMD opencl icd signal dispatch bugs)
  • opencv csc was too slow

@totaam totaam closed this as completed Dec 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant