Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unicode window titles do not work on XP #526

Closed
totaam opened this issue Mar 4, 2014 · 7 comments
Closed

unicode window titles do not work on XP #526

totaam opened this issue Mar 4, 2014 · 7 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 4, 2014

Issue migrated from trac ticket # 526

component: platforms | priority: major | resolution: wontfix | keywords: win32

2014-03-04 05:47:07: totaam created the issue


GTK requires all window titles to be sent as UTF-8, which we now do explicitly (see r5694), but even with the patch attached which uses user32.SetWindowTextW on the window handle to bypass GTK and set the window title using UTF-16, we still get gibberish in the title bar...

The patch also checks and the window does support unicode (isWindowUnicode()==1).

This can be tested with [/browser/xpra/trunk/src/tests/xpra/test_apps/test_window_title.py tests.xpra.test_apps.test_window_title]

@totaam
Copy link
Collaborator Author

totaam commented Mar 4, 2014

2014-03-04 05:47:34: totaam uploaded file win32-utf16-title.patch (2.1 KiB)

tries to use SetWindowTextW to set the window title

@totaam
Copy link
Collaborator Author

totaam commented Mar 4, 2014

2014-03-04 06:15:22: totaam uploaded file win32-utf16-title-MultiByteToWideChar.patch (2.9 KiB)

alternative patch using MultiByteToWideChar instead of encode to utf-16-le

@totaam
Copy link
Collaborator Author

totaam commented Apr 22, 2015

2015-04-22 09:29:13: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Apr 22, 2015

2015-04-22 09:29:13: antoine set resolution to wontfix

@totaam
Copy link
Collaborator Author

totaam commented Apr 22, 2015

2015-04-22 09:29:13: antoine changed title from unicode window titles do not work on win32 to unicode window titles do not work on XP

@totaam
Copy link
Collaborator Author

totaam commented Apr 22, 2015

2015-04-22 09:29:13: antoine commented


Turns out that this is a limitation of XP, works fine with win7 (see #826).

So I don't think we can fix this.

@totaam totaam closed this as completed Apr 22, 2015
@totaam
Copy link
Collaborator Author

totaam commented Nov 28, 2015

2015-11-28 09:57:51: antoine edited the issue description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant