Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 client maximize does not follow browser canvas size #821

Closed
totaam opened this issue Mar 4, 2015 · 16 comments
Closed

html5 client maximize does not follow browser canvas size #821

totaam opened this issue Mar 4, 2015 · 16 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Mar 4, 2015

Issue migrated from trac ticket # 821

component: client | priority: major | resolution: fixed | keywords: html5 client maximize

2015-03-04 22:13:40: aradtech created the issue


When a application is maximized in html5 client the application does not resize along with the browser canvas.

IE maximize midori in the html5 client and resize the browser window.

Also note that when the browser canvas has been resized the application even when minimize then re maximized does not conform to the correct size.

Test on windows in Chrome, Firefox.

@totaam
Copy link
Collaborator Author

totaam commented Mar 4, 2015

2015-03-04 22:14:16: aradtech edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Mar 4, 2015

2015-03-04 22:15:32: aradtech edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Mar 5, 2015

2015-03-05 05:04:10: totaam changed owner from antoine to joshiggins

@totaam
Copy link
Collaborator Author

totaam commented Mar 5, 2015

2015-03-05 13:04:26: joshiggins changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Mar 5, 2015

2015-03-05 13:04:26: joshiggins commented


Yes, the HTML5 client needs to implement sending screen size updates!

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 17:14:05: joshiggins commented


r9101 and r9103 implement the required functionality to send screen size updates.

I can see server acknowledge request with

2015-04-21 17:04:26,156 resolution not found for 1439x399
2015-04-21 17:04:26,156 received updated display dimensions
2015-04-21 17:04:26,156 client root window size is 1439x399 with 1 displays:
2015-04-21 17:04:26,156   'HTML' (381x106 mm - DPI: 95x95)
2015-04-21 17:04:26,156     Canvas

and any maximised windows on the page resize accordingly.

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 19:15:22: aradtech changed status from assigned to closed

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 19:15:22: aradtech set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 19:15:22: aradtech commented


Tested and confirmed working , good job Josh :)

Closing unless issues occur.

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 19:27:14: aradtech changed status from closed to reopened

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 19:27:14: aradtech removed resolution (was fixed)

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 19:27:14: aradtech commented


Found small issue , title bar is still active and allows you to drag window around inside html canvas , this is not desired behavior - title bar should be disabled from dragging.

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 21:22:58: joshiggins commented


Good catch! Fixed for me in r9107, let me know how it goes.

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 21:34:37: aradtech changed status from reopened to closed

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 21:34:37: aradtech set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Apr 21, 2015

2015-04-21 21:34:37: aradtech commented


Tested and fixed ,closing again as I have found nothing else :)

@totaam totaam closed this as completed Apr 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant