Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean function in YAMJ deletes the overlay images #2262

Closed
Omertron opened this issue Mar 15, 2015 · 10 comments
Closed

Clean function in YAMJ deletes the overlay images #2262

Omertron opened this issue Mar 15, 2015 · 10 comments

Comments

@Omertron
Copy link
Member

Original issue 2263 created by Omertron on 2012-01-09T00:18:15.000Z:

What steps will reproduce the problem?

  1. Run YAMJ with file clean
  2. When cleaning out unused files the newly created overlay files are deleted.
    3.

What is the expected output? What do you see instead?
All created overlay files should remain in the jukebox

What version/revision of YAMJ are you using? On what operating system?
r2873

What skin are you using?
eversion

What device are you using YAMJ on? Networked Media Tank, PlayonHD, Other?
C-200

Please provide any additional information below.

@Omertron
Copy link
Member Author

Comment #1 originally posted by Omertron on 2012-01-11T17:19:59.000Z:

Have you used the property mjb.clean.skip in the skin.properties file?

@Omertron
Copy link
Member Author

Comment #2 originally posted by Omertron on 2012-01-11T19:59:39.000Z:

Yes and no
Only the moviejukebox command -c switch is used but the eversion skin uses it:
mjb.clean.skip=eversion.phf|eversion.swf

I had this reported as an error with the evhell 3.0 skin.

Should I ask accident to add .footer.png to mjb.clean.skip in skin.properties to solve it?

@Omertron
Copy link
Member Author

Comment #3 originally posted by Omertron on 2012-01-11T20:39:29.000Z:

Yes adding that to the property will prevent it being deleted
You can test it yourself with the property to make sure you keep all the required files

@Omertron
Copy link
Member Author

Comment #4 originally posted by Omertron on 2012-01-11T21:54:52.000Z:

I'm getting a java error when trying that:

Cleaning up the jukebox directory...
Exception in thread "main" java.util.regex.PatternSyntaxException: Dangling meta character '' near index 26
eversion.phf|eversion.swf|
.footer*.png
^
at java.util.regex.Pattern.error(Unknown Source)
at java.util.regex.Pattern.sequence(Unknown Source)
at java.util.regex.Pattern.expr(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at java.util.regex.Pattern.(Unknown Source)
at java.util.regex.Pattern.compile(Unknown Source)
at com.moviejukebox.MovieJukebox.cleanJukeboxFolder(MovieJukebox.java:1678)
at com.moviejukebox.MovieJukebox.generateLibrary(MovieJukebox.java:1608)
at com.moviejukebox.MovieJukebox.main(MovieJukebox.java:462)

@Omertron
Copy link
Member Author

Comment #5 originally posted by Omertron on 2012-01-11T22:10:11.000Z:

It needs to be a Java REGEX for it to work
Try "(.)footer(.)png$"

@Omertron
Copy link
Member Author

Comment #6 originally posted by Omertron on 2012-01-12T07:33:03.000Z:

Thank you that fixed it.

@Omertron
Copy link
Member Author

Comment #7 originally posted by Omertron on 2012-01-12T15:31:42.000Z:

That just caused a new bug.. All you did was stop deleting all the footer files, even when a title is removed and should be cleaned up..

Nice fast workaround, but not really fixed.

@Omertron
Copy link
Member Author

Comment #8 originally posted by Omertron on 2012-01-12T15:33:55.000Z:

spoke to stuart, he thought these were skin files and not aware footer files are made for each title if you use the feature.. :)

@Omertron
Copy link
Member Author

Comment #9 originally posted by Omertron on 2012-01-12T15:36:30.000Z:

The footer filename needs to be added to the FileTools.addJukeboxFile() function

@Omertron
Copy link
Member Author

Comment #10 originally posted by Omertron on 2012-01-12T15:52:59.000Z:

This issue was closed by revision r2885.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant