Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

bnx2x: fix a crash on corrupt firmware file

If the requested firmware is deemed corrupt and then released, reset the
pointer to NULL in order to avoid double-freeing it in
bnx2x_release_firmware() or dereferencing it in bnx2x_init_firmware().

Signed-off-by: Michal Schmidt <mschmidt@redhat.com>
Acked-by: Eilon Greenstein <eilong@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information...
commit 127d0a198a310970b31866af8bbb6d4b1068e546 1 parent cc34eb6
@michich michich authored davem330 committed
Showing with 1 addition and 0 deletions.
  1. +1 −0  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
View
1  drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c
@@ -10901,6 +10901,7 @@ int bnx2x_init_firmware(struct bnx2x *bp)
kfree(bp->init_data);
request_firmware_exit:
release_firmware(bp->firmware);
+ bp->firmware = NULL;
return rc;
}
Please sign in to comment.
Something went wrong with that request. Please try again.