Skip to content

Commit

Permalink
[PATCH] ppc64: fix prom.c compile warning
Browse files Browse the repository at this point in the history
The code in unflatten_device_tree knows that get_property is written to
only return with lenp equal to 1 when also returning a valid pointer.
The gcc 3.3.3 compiler is not able to prove this to itself, so it warns
about a possible uninitialized pointer dereference:

 .../arch/ppc64/kernel/prom.c: In function `unflatten_device_tree':
 .../arch/ppc64/kernel/prom.c:828:
 warning: `p' might be used uninitialized in this function

Unless it is desired to rework the interaction between the two
functions, this will keep the existing behavior but quiet the compiler.

Signed-off-by: Amos Waterland <apw@us.ibm.com>
Signed-off-by: Paul Mackerras <paulus@samba.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
paulusmack authored and Linus Torvalds committed May 6, 2005
1 parent 6741f3a commit 3892c5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/ppc64/kernel/prom.c
Expand Up @@ -834,7 +834,7 @@ void __init unflatten_device_tree(void)
{
unsigned long start, mem, size;
struct device_node **allnextp = &allnodes;
char *p;
char *p = NULL;
int l = 0;

DBG(" -> unflatten_device_tree()\n");
Expand Down

0 comments on commit 3892c5f

Please sign in to comment.