Skip to content

Commit

Permalink
cfq-iosched: Do not access cfqq after freeing it
Browse files Browse the repository at this point in the history
Fix a crash during boot reported by Jeff Moyer. Fix the issue of accessing
cfqq after freeing it.

Reported-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reviewed-by: Jeff Moyer <jmoyer@redhat.com>
Signed-off-by: Jens Axboe <axboe@carl.(none)>
  • Loading branch information
rhvgoyal authored and Jens Axboe committed Dec 7, 2009
1 parent accee78 commit 878eadd
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions block/cfq-iosched.c
Expand Up @@ -2368,7 +2368,7 @@ static int cfq_dispatch_requests(struct request_queue *q, int force)
static void cfq_put_queue(struct cfq_queue *cfqq)
{
struct cfq_data *cfqd = cfqq->cfqd;
struct cfq_group *cfqg;
struct cfq_group *cfqg, *orig_cfqg;

BUG_ON(atomic_read(&cfqq->ref) <= 0);

Expand All @@ -2379,6 +2379,7 @@ static void cfq_put_queue(struct cfq_queue *cfqq)
BUG_ON(rb_first(&cfqq->sort_list));
BUG_ON(cfqq->allocated[READ] + cfqq->allocated[WRITE]);
cfqg = cfqq->cfqg;
orig_cfqg = cfqq->orig_cfqg;

if (unlikely(cfqd->active_queue == cfqq)) {
__cfq_slice_expired(cfqd, cfqq, 0);
Expand All @@ -2388,8 +2389,8 @@ static void cfq_put_queue(struct cfq_queue *cfqq)
BUG_ON(cfq_cfqq_on_rr(cfqq));
kmem_cache_free(cfq_pool, cfqq);
cfq_put_cfqg(cfqg);
if (cfqq->orig_cfqg)
cfq_put_cfqg(cfqq->orig_cfqg);
if (orig_cfqg)
cfq_put_cfqg(orig_cfqg);
}

/*
Expand Down

0 comments on commit 878eadd

Please sign in to comment.