Skip to content

Commit

Permalink
[NETFILTER]: Rename misnamed function
Browse files Browse the repository at this point in the history
Both __ip_conntrack_expect_find and ip_conntrack_expect_find_get take
a reference to the expectation, the difference is that callers of
__ip_conntrack_expect_find must hold ip_conntrack_lock.

Signed-off-by: Patrick McHardy <kaber@trash.net>
Signed-off-by: Harald Welte <laforge@netfilter.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
kaber authored and davem330 committed Sep 19, 2005
1 parent e674d0f commit a41bc00
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion include/linux/netfilter_ipv4/ip_conntrack.h
Expand Up @@ -384,7 +384,7 @@ extern struct ip_conntrack_expect *
__ip_conntrack_expect_find(const struct ip_conntrack_tuple *tuple);

extern struct ip_conntrack_expect *
ip_conntrack_expect_find_get(const struct ip_conntrack_tuple *tuple);
ip_conntrack_expect_find(const struct ip_conntrack_tuple *tuple);

extern struct ip_conntrack_tuple_hash *
__ip_conntrack_find(const struct ip_conntrack_tuple *tuple,
Expand Down
2 changes: 1 addition & 1 deletion net/ipv4/netfilter/ip_conntrack_core.c
Expand Up @@ -233,7 +233,7 @@ __ip_conntrack_expect_find(const struct ip_conntrack_tuple *tuple)

/* Just find a expectation corresponding to a tuple. */
struct ip_conntrack_expect *
ip_conntrack_expect_find_get(const struct ip_conntrack_tuple *tuple)
ip_conntrack_expect_find(const struct ip_conntrack_tuple *tuple)
{
struct ip_conntrack_expect *i;

Expand Down
4 changes: 2 additions & 2 deletions net/ipv4/netfilter/ip_conntrack_netlink.c
Expand Up @@ -1270,7 +1270,7 @@ ctnetlink_get_expect(struct sock *ctnl, struct sk_buff *skb,
if (err < 0)
return err;

exp = ip_conntrack_expect_find_get(&tuple);
exp = ip_conntrack_expect_find(&tuple);
if (!exp)
return -ENOENT;

Expand Down Expand Up @@ -1318,7 +1318,7 @@ ctnetlink_del_expect(struct sock *ctnl, struct sk_buff *skb,
return err;

/* bump usage count to 2 */
exp = ip_conntrack_expect_find_get(&tuple);
exp = ip_conntrack_expect_find(&tuple);
if (!exp)
return -ENOENT;

Expand Down
4 changes: 2 additions & 2 deletions net/ipv4/netfilter/ip_conntrack_standalone.c
Expand Up @@ -993,11 +993,11 @@ EXPORT_SYMBOL(ip_ct_refresh_acct);

EXPORT_SYMBOL(ip_conntrack_expect_alloc);
EXPORT_SYMBOL(ip_conntrack_expect_put);
EXPORT_SYMBOL_GPL(ip_conntrack_expect_find_get);
EXPORT_SYMBOL_GPL(__ip_conntrack_expect_find);
EXPORT_SYMBOL_GPL(ip_conntrack_expect_find);
EXPORT_SYMBOL(ip_conntrack_expect_related);
EXPORT_SYMBOL(ip_conntrack_unexpect_related);
EXPORT_SYMBOL_GPL(ip_conntrack_expect_list);
EXPORT_SYMBOL_GPL(__ip_conntrack_expect_find);
EXPORT_SYMBOL_GPL(ip_ct_unlink_expect);

EXPORT_SYMBOL(ip_conntrack_tuple_taken);
Expand Down

0 comments on commit a41bc00

Please sign in to comment.