Please sign in to comment.
perf tools: Incorrect use of snprintf results in SEGV
I have a workload where perf top scribbles over the stack and we SEGV. What makes it interesting is that an snprintf is causing this. The workload is a c++ gem that has method names over 3000 characters long, but snprintf is designed to avoid overrunning buffers. So what went wrong? The problem is we assume snprintf returns the number of characters written: ret += repsep_snprintf(bf + ret, size - ret, "[%c] ", self->level); ... ret += repsep_snprintf(bf + ret, size - ret, "%s", self->ms.sym->name); Unfortunately this is not how snprintf works. snprintf returns the number of characters that would have been written if there was enough space. In the above case, if the first snprintf returns a value larger than size, we pass a negative size into the second snprintf and happily scribble over the stack. If you have 3000 character c++ methods thats a lot of stack to trample. This patch fixes repsep_snprintf by clamping the value at size - 1 which is the maximum snprintf can write before adding the NULL terminator. I get the sinking feeling that there are a lot of other uses of snprintf that have this same bug, we should audit them all. Cc: David Ahern <firstname.lastname@example.org> Cc: Eric B Munson <email@example.com> Cc: Frederic Weisbecker <firstname.lastname@example.org> Cc: Ingo Molnar <email@example.com> Cc: Paul Mackerras <firstname.lastname@example.org> Cc: Peter Zijlstra <email@example.com> Cc: Yanmin Zhang <firstname.lastname@example.org> Cc: email@example.com Link: http://lkml.kernel.org/r/20120307114249.44275ca3@kryten Signed-off-by: Anton Blanchard <firstname.lastname@example.org> Signed-off-by: Arnaldo Carvalho de Melo <email@example.com>
- Loading branch information...