Please sign in to comment.
perf: Initialize callchains roots's childen hits
commit 5225c45 upstream. Each histogram entry has a callchain root that stores the callchain samples. However we forgot to initialize the tracking of children hits of these roots, which then got random values on their creation. The root children hits is multiplied by the minimum percentage of hits provided by the user, and the result becomes the minimum hits expected from children branches. If the random value due to the uninitialization is big enough, then this minimum number of hits can be huge and eventually filter every children branches. The end result was invisible callchains. All we need to fix this is to initialize the children hits of the root. Reported-by: Christoph Hellwig <firstname.lastname@example.org> Signed-off-by: Frederic Weisbecker <email@example.com> Cc: Ingo Molnar <firstname.lastname@example.org> Cc: Peter Zijlstra <email@example.com> Cc: Arnaldo Carvalho de Melo <firstname.lastname@example.org> Cc: Paul Mackerras <email@example.com> Signed-off-by: Greg Kroah-Hartman <firstname.lastname@example.org>
- Loading branch information...