Skip to content

Commit

Permalink
amd64_edac: Remove node interleave warning
Browse files Browse the repository at this point in the history
This warning was wrongfully added for a normal condition - intlvsel
actually selects the destination node when node interleaving is enabled
and it is not a mismatch. For a detailed example, see section 2.8.10.2
"Node Interleaving" in F10h BKDG.

Signed-off-by: Borislav Petkov <borislav.petkov@amd.com>
  • Loading branch information
Borislav Petkov committed Apr 26, 2011
1 parent 4949603 commit f030ddf
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/edac/amd64_edac.c
Expand Up @@ -1401,12 +1401,8 @@ static int f1x_match_to_this_node(struct amd64_pvt *pvt, unsigned range,
return -EINVAL;
}

if (intlv_en &&
(intlv_sel != ((sys_addr >> 12) & intlv_en))) {
amd64_warn("Botched intlv bits, en: 0x%x, sel: 0x%x\n",
intlv_en, intlv_sel);
if (intlv_en && (intlv_sel != ((sys_addr >> 12) & intlv_en)))
return -EINVAL;
}

sys_addr = f1x_swap_interleaved_region(pvt, sys_addr);

Expand Down

0 comments on commit f030ddf

Please sign in to comment.