Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookmarklets may fail on pages which title is a URL #1672

Open
ozh opened this issue Apr 10, 2014 · 2 comments
Open

Bookmarklets may fail on pages which title is a URL #1672

ozh opened this issue Apr 10, 2014 · 2 comments
Labels
api bug Something isn't working

Comments

@ozh
Copy link
Member

ozh commented Apr 10, 2014

As seen in #1670 : if a document <title> is a URL, the bookmarklet will generate a &t=http://... which will make mod_security trip up

Possible fix would be to split the title like we did with the URL at any http: part but :

  • what if multiple 'http://' occurences?
  • is it multibyte safe? (is that a concern anyway?)
  • ?
@ozh ozh added this to the 1.7.1 milestone Apr 10, 2014
@ozh
Copy link
Member Author

ozh commented Dec 5, 2014

I have something functional, able to split a string on any and multiple protocols and build a query string that will allow to glue the string back together, but it's probably way too overkill and way too long for a bookmarklet. Oh well. For posterity or potential future use: https://gist.github.com/ozh/42eb3a09d3de088ff11b

@ozh ozh removed this from the 1.7.1 milestone Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants