Unnecessary Encoding of percent sign #1973

Open
SirLouen opened this Issue Nov 2, 2015 · 3 comments

Projects

None yet

2 participants

@SirLouen
SirLouen commented Nov 2, 2015

If I'm already encoding the URL with % signs, I dont know why the system reecondes the % with %25

I need to "preencode" because google play only admits preencoded referrer tag

For example:
https://play.google.com/store/apps/details?id=com.twitter&referrer=utm_source%3Dtwitter%26utm_medium%3Dsocialmedia%26utm_campaign%3Dtwittercampaign

The first part of the URL
https://play.google.com/store/apps/details?id=com.twitter&referrer=
Has to be not encoded

But from that point:
utm_source%3Dtwitter%26utm_medium%3Dsocialmedia%26utm_campaign%3Dtwittercampaign
Has to be preencoded

The output of yourls:
https://play.google.com/store/apps/details?id=com.twitter&referrer=utm_source%253Dtwitter%2526utm_medium%253Dsocialmedia%2526utm_campaign%253Dtwittercampaign

It double encodes the % simbols with %25 unnecessarily.

@LeoColomb
Member

Ref: #1303

@SirLouen
SirLouen commented Nov 2, 2015

I'm trying https://github.com/adigitalife/yourls-fix-long-url to solve this
Lets see if I resolve it

@SirLouen
SirLouen commented Nov 2, 2015

Impossible. I've tried that plugin and it does not work neither. This functionality looks broken

EDIT: Following this little fix, works fine
#1651

But what i see is that if I edit for example the Title of the url in the admin platform, the system will try to recode again. So It only solves the new url system, but not the updates and editings 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment