New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding breaks firebase storage links #2153

Open
tomermes opened this Issue Sep 29, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@tomermes

tomermes commented Sep 29, 2016

This is a sample firebase storage url:

https://firebasestorage.googleapis.com/v0/b/my-app-id.appspot.com/o/images%2F1472226525901.png?alt=media&token=24ae5256-514d-1126-7a00-f1ce822050ce

When shortened the url saved in the db is with "/" instead of %2F (after images token).
Firebase domain return 404 for those links.

@tomermes

This comment has been minimized.

Show comment
Hide comment
@tomermes

tomermes Sep 29, 2016

You can remove the encoding of the url in includes/functions.php, at the function "yourls_add_new_link".
Just remove the two rows which makes encodeURI and escape.

tomermes commented Sep 29, 2016

You can remove the encoding of the url in includes/functions.php, at the function "yourls_add_new_link".
Just remove the two rows which makes encodeURI and escape.

@tomermes tomermes closed this Sep 29, 2016

@dgw

This comment has been minimized.

Show comment
Hide comment
@dgw

dgw Sep 29, 2016

Collaborator

Don't Hack Core!

This should be tweakable with a plugin, or perhaps YOURLS should not be decoding entities in URLs like this one.

Collaborator

dgw commented Sep 29, 2016

Don't Hack Core!

This should be tweakable with a plugin, or perhaps YOURLS should not be decoding entities in URLs like this one.

@tomermes

This comment has been minimized.

Show comment
Hide comment
@tomermes

tomermes Oct 2, 2016

ok so fix needed

tomermes commented Oct 2, 2016

ok so fix needed

@tomermes tomermes reopened this Oct 2, 2016

@LeoColomb

This comment has been minimized.

Show comment
Hide comment
@LeoColomb

LeoColomb Oct 2, 2016

Member

X-Ref: #1303

Member

LeoColomb commented Oct 2, 2016

X-Ref: #1303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment