New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter 140 character limit #2352

Closed
JayHoltslander opened this Issue Jan 10, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@JayHoltslander

JayHoltslander commented Jan 10, 2018

Twitter has updated their character limit to 280 characters now. Would be nice if the share dialog reflected this.

@majordome

This comment has been minimized.

Show comment
Hide comment
@majordome

majordome bot Jan 10, 2018

Hey @JayHoltslander, thanks for opening an issue!

Unfortunately, it seems you are missing information from the issue template.
Make sure it has all the necessary details as described in our contribution guidelines.

majordome bot commented Jan 10, 2018

Hey @JayHoltslander, thanks for opening an issue!

Unfortunately, it seems you are missing information from the issue template.
Make sure it has all the necessary details as described in our contribution guidelines.

@dgw

This comment has been minimized.

Show comment
Hide comment
@dgw

dgw Jan 10, 2018

Collaborator

Oh now @majordome chimes in?

I took a look at the share code… Expect a PR by the weekend with this and probably a few other fixes. At first glance, there are multiple things I could tweak along with the character count.

Collaborator

dgw commented Jan 10, 2018

Oh now @majordome chimes in?

I took a look at the share code… Expect a PR by the weekend with this and probably a few other fixes. At first glance, there are multiple things I could tweak along with the character count.

@dgw dgw self-assigned this Jan 10, 2018

dgw added a commit to dgw/YOURLS that referenced this issue Jan 14, 2018

@dgw dgw referenced this issue Jan 14, 2018

Merged

Share tweaks #2357

@ozh ozh closed this in #2357 Jan 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment