New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order by Title #2356

Closed
271289 opened this Issue Jan 13, 2018 · 5 comments

Comments

Projects
None yet
4 participants
@271289

271289 commented Jan 13, 2018

Is there any possibility to order by title in the admin interface?

At the end of admin interface you can order by

  • Short URL
  • URL
  • Date
  • IP
  • Clicks

...but not by "Title".

My titles look like this

  • "Product 1 > Link 1"
  • "Product 1 > Link 2"
  • "Product 2 > Link 1"
  • "Product 2 > Link 2"

...and it would be nice to see them in this order.

I tried to add the line
'title' => yourls__( 'Title' ),
below

// Second search control: order by
$_options = array(
    'keyword'      => yourls__( 'Short URL' ),
    'url'          => yourls__( 'URL' ),

in the file /includes/functions-html.php ...but that doesn't do the trick :(

@majordome

This comment has been minimized.

majordome bot commented Jan 13, 2018

Hey @271289, thanks for opening an issue!

Unfortunately, it seems you are missing information from the issue template.
Make sure it has all the necessary details as described in our contribution guidelines.

@ozh

This comment has been minimized.

Member

ozh commented Jan 14, 2018

Indeed, it's not possible out of the box. Someone should make a pull request to add this feature.

@ozh ozh closed this Jan 14, 2018

@dgw

This comment has been minimized.

Collaborator

dgw commented Jan 14, 2018

Why does @majordome only chime in on tickets that are missing the issue template because they're feature requests? (Just kidding, but it's funny to see when it does and doesn't post.)

@ozh I'm going to reopen and assign this to myself. That "someone" might as well be me, and keeping the issue open will keep it on my issue dashboard until I actually make the PR.

@dgw dgw reopened this Jan 14, 2018

@dgw dgw self-assigned this Jan 14, 2018

@LeoColomb

This comment has been minimized.

Member

LeoColomb commented Jan 14, 2018

@dgw Regarding majordome, it's because I host the bot on zeit now, which kill the server after some time of inactivity. The restart is 2 sec too long for GitHub webhooks, then we got request timeouts.
So, depending of the repo activity, it will reply if the server is still active.
I'm considering changing to a new lambda free host, I just need some free time! 😄

@dgw dgw removed the help wanted label Mar 1, 2018

dgw added a commit to dgw/YOURLS that referenced this issue Mar 1, 2018

@dgw

This comment has been minimized.

Collaborator

dgw commented Mar 1, 2018

Yes, that ticket reference means I'm working on an implementation of this. 😁

PR tomorrow, probably. Barring any explosions once I pull the patch to my server for testing, that is. My PHP is pretty rusty, after all. 😏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment