Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PostgreSQL support with the now used PDO library #2487

Open
doronbehar opened this issue Jan 9, 2019 · 6 comments · May be fixed by #2875
Open

PostgreSQL support with the now used PDO library #2487

doronbehar opened this issue Jan 9, 2019 · 6 comments · May be fixed by #2875

Comments

@doronbehar
Copy link

@doronbehar doronbehar commented Jan 9, 2019

Technical details regarding my environment

  • YOURLS version: 1.7.3
  • PHP version: 7.3

This is more of a feature request. I've read #448 and #2239 and I've learned that making YOURLS use PostgreSQL instead of MySQL is possible by creating a plugin as noted here. But since commit a190d2f, YOURLS uses PDO so from what I understand, PostgreSQL support should be available without even creating a plugin.

@HeapUnderfl0w
Copy link

@HeapUnderfl0w HeapUnderfl0w commented Oct 3, 2019

Is there any update for this?

Attempting to set it up using postgres/pdo, but it just doesn't seem to work really. (i think its something on my end, but a small "how to" would be nice)

@doronbehar
Copy link
Author

@doronbehar doronbehar commented Oct 3, 2019

@HeapUnderfl0w If you wish, you can use my fork which is based on @iWantToKeepAnon's fork along with upstream's 1.7.4 changes merged (as suggested here).

@HeapUnderfl0w
Copy link

@HeapUnderfl0w HeapUnderfl0w commented Oct 3, 2019

you my sir are a godsend, thank you very much.

@ozh
Copy link
Member

@ozh ozh commented Oct 5, 2019

@doronbehar any chance this could be packaged as a plugin ?

@doronbehar
Copy link
Author

@doronbehar doronbehar commented Oct 5, 2019

@ozh I don't think it should. There should be a configuration value for that instead. TBH, I'm no PHP developer and I'm just a happy user. @iWantToKeepAnon, which is the original author of this fork, commented in #2239:

But I am content right now to use it and merge upstream changes down into this repo as needed. I'm not sure I have the time or interest to modularize the project, and not sure @ozh would accept such a grand architecture PR anyway.

For reference, here's a link to the diff between my fork (rebased to 1.7.4) and upstream:

master...doronbehar:master

I think it shouldn't be that hard to modularize it but I'm not experienced enough with the PHP ecosystem / development tools to dive in.

@whalehub
Copy link
Contributor

@whalehub whalehub commented Nov 8, 2020

@ozh Any update on this?

@LeoColomb LeoColomb linked a pull request that will close this issue Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants