Created SVG version of YOURLS logo #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Man, that's truly awesome. I guess SVG graphics are totally cross browser compatible these days? Should we keep the .png as is (instead of replacing it as your commit does) and use the .svg instead in files, eg .HTML, .MD and such? |
|
Yeah an svg will work in a regular img tag these days in nearly every
browser.
In retrospect... if some file somewhere is linking to the .png then it
would 404 rather than using the .svg so maybe total replacement of the png
isn't safe without checking other files first.
…On Mon, Sep 2, 2019 at 3:58 PM ྅༻ Ǭɀħ ༄༆ཉ ***@***.***> wrote:
Man, that's truly awesome. I guess SVG graphics are totally cross browser
compatible these days? Should we keep the .png as is (instead of replacing
it as your commit does) and use the .svg instead in files, eg .HTML, .MD
and such?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2548?email_source=notifications&email_token=AAPZLSFZFPTL2GLAAPZBGWLQHWLCRA5CNFSM4ITAL2FKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5WUIQY#issuecomment-527254595>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPZLSEJGW3WVUHYUYGP5CTQHWLCRANCNFSM4ITAL2FA>
.
--
Jay Holtslander
https://jay.holtslander.ca
|
Indeed! That should be easy, though. |
|
@JayHoltslander could you remove the first commit so we keep the .png along with the new .svg? This way we'll just use the newer file but won't break anything using the png one |
|
Sorry about the slow reply. Will try to do this evening. |
|
@ozh Rebased myself, since we've been waiting several weeks now. Ready to merge if you like, unless it bugs you to have the author & committer be different. |
dgw
approved these changes
Nov 2, 2019
Art4
approved these changes
Nov 21, 2019
doronbehar
added a commit
to doronbehar/YOURLS
that referenced
this pull request
Feb 11, 2020
* 'master' of https://github.com/YOURLS/YOURLS: Bump for next release Bump bumped version number (YOURLS#2595) Add vector version of YOURLS logo (YOURLS#2548) Trim overlong client information (YOURLS#2574) Rearrange opencollective badges Add jsonp parameter in API as a fallback to match documentation (YOURLS#2567) Update plugin.php (YOURLS#2562) Fix composer warning about uppercase in require block (YOURLS#2557) Split test in 2 (YOURLS#2558) Core-ify "Random Keywords" plugin (YOURLS#2367)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old raster logo painstakingly recreated as a vector graphic.