Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random ShortURLs error #2561

Closed
garanda21 opened this issue Oct 4, 2019 · 4 comments

Comments

@garanda21
Copy link

commented Oct 4, 2019

Plugin Random ShortURLs has an error on its code, after activate it not working properly.

After review plugin.php code the filter assignation seems to be wrong, it says:

yourls_add_filter( 'random_shorturl', 'ozh_random_shorturl' );

After replacing to:

yourls_add_filter( 'random_keyword', 'ozh_random_shorturl' );

Plugins works as expected.

@LeoColomb

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Thanks for opening this issue, @garanda21!

You're right. Could you open a pull request with this change?
Thanks! 👍

@ozh ozh closed this in fbba93d Oct 4, 2019
@ozh

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Thanks @garanda21

@dgw

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Lol, I must have messed up a global find-and-replace long ago when first migrating that plugin to core. Thanks!

@dgw dgw added the bug label Oct 4, 2019
@garanda21

This comment has been minimized.

Copy link
Author

commented Oct 4, 2019

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.