Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import unit-tests inside the main repo #2326

Merged
merged 269 commits into from Sep 21, 2019

Conversation

@LeoColomb
Copy link
Member

commented Nov 28, 2017

As discussed in #2301, it would be easier (and more common) to manage unit-tests directly in the main YOURLS repository.

The git log from YOURS-unit-tests repo is kept.

@LeoColomb LeoColomb force-pushed the feat/tests-with-git branch from 65ae56c to 09d3258 Nov 28, 2017
@LeoColomb LeoColomb force-pushed the master branch from d53bcc9 to bb357e3 Nov 28, 2017
@LeoColomb LeoColomb force-pushed the feat/tests-with-git branch from 09d3258 to 150a26c Nov 28, 2017
@LeoColomb LeoColomb requested review from dgw and ozh Nov 28, 2017
@LeoColomb LeoColomb self-assigned this Nov 28, 2017
@LeoColomb LeoColomb changed the title Import unit-tests inside main repo Import unit-tests inside the main repo Nov 28, 2017
@dgw
dgw approved these changes Nov 28, 2017
Copy link
Member

left a comment

Looks like Travis is finding and running the tests just fine. I skimmed a couple of the logs, and it looks a-OK.

No, I didn't examine every one of the 260-odd commits imported from the unit-tests repo, but what's important is that the tests work in the main repo. 👍

@LeoColomb LeoColomb force-pushed the feat/tests-with-git branch from 018fe12 to 1fd8550 Nov 28, 2017
@LeoColomb LeoColomb added this to To do in YOURLS via automation Nov 29, 2017
@LeoColomb LeoColomb moved this from To do to In progress in YOURLS Nov 29, 2017
@LeoColomb LeoColomb added the tests label Nov 29, 2017
@ozh

This comment has been minimized.

Copy link
Member

commented Dec 1, 2017

For the record, I'm moving house tuesday, no time to review or test or comment such a change, I'll be mostly offline for some days at least. Nice work Leo in any case :) I'll have a look on this asap!

@LeoColomb LeoColomb moved this from In progress to Ready in YOURLS Mar 9, 2019
@LeoColomb LeoColomb referenced this pull request Sep 21, 2019
@LeoColomb LeoColomb force-pushed the feat/tests-with-git branch 4 times, most recently from 6e2c3d9 to 203dbc2 Sep 21, 2019
Co-authored-by: Chun-Sheng, Li <peter279k@gmail.com>
@LeoColomb LeoColomb force-pushed the feat/tests-with-git branch from 203dbc2 to d764480 Sep 21, 2019
@LeoColomb LeoColomb merged commit b8f2eaa into master Sep 21, 2019
3 checks passed
3 checks passed
Scrutinizer 119 new issues, 357 updated code elements
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
YOURLS automation moved this from Ready to Done Sep 21, 2019
@LeoColomb LeoColomb deleted the feat/tests-with-git branch Sep 21, 2019
@ozh

This comment has been minimized.

Copy link
Member

commented Sep 22, 2019

Really neat. Does that mean yourls/yourls-unit-tests is now deprecated, or should we keep it for some reason?
(oh, just saw the "Archived" status. Perfect)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
YOURLS
  
Done
3 participants
You can’t perform that action at this time.