New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove referrer meta tag from admin head #2435

Merged
merged 1 commit into from Sep 14, 2018

Conversation

Projects
None yet
2 participants
@dgw
Collaborator

dgw commented Sep 14, 2018

It's not clear why this tag was added, and it's even less clear what benefit there would be to keeping it. Its only real function seems to be leaking YOURLS' admin panel location (see #2432), which is not desirable.

A hook (or hooks) will likely be added to let plugins control referrer behavior, by adding the relevant HTTP header(s) and/or meta tag(s). (Separate PR, probably, because exactly what to do is still being defined.)

Remove referrer meta tag from admin head
It's not clear why this tag was added, and it's even less clear what
benefit there would be to keeping it. Its only real function seems to be
leaking YOURLS' admin panel location (see #2432), which is not desirable.

A hook (or hooks) will likely be added to let plugins control referrer
behavior, by adding the relevant HTTP header(s) and/or meta tag(s).

@dgw dgw added this to the 1.8 milestone Sep 14, 2018

@ozh ozh merged commit 9c0609a into YOURLS:master Sep 14, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dgw dgw deleted the dgw:hands-off-referrers branch Sep 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment