New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add top, bottom, and end hooks to the login form #2439

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
2 participants
@dgw
Collaborator

dgw commented Sep 17, 2018

Plugins can use these to add extra fields, for OpenID login, accepting two-factor authentication codes, etc.

Fixes #2436. I'm not super attached to these hook names; they just made sense as a set. Happy to change them if someone else thinks of clearer names, or if they don't fit well enough with the existing hooks.

Add top, bottom, and end hooks to the login form
Plugins can use these to add extra fields, for OpenID login, accepting
two-factor authentication codes, etc.

Fixes #2436.

@dgw dgw added this to the 1.8 milestone Sep 17, 2018

@dgw

This comment has been minimized.

Show comment
Hide comment
@dgw

dgw Sep 17, 2018

Collaborator

Test failure seems to be from HTTPbin flakiness, as each build job on Travis shows slightly different failures all in the Requests batch. What can you do, I guess… (Besides running a local HTTP server during the test phase instead of calling out to an external service, that is.)

Collaborator

dgw commented Sep 17, 2018

Test failure seems to be from HTTPbin flakiness, as each build job on Travis shows slightly different failures all in the Requests batch. What can you do, I guess… (Besides running a local HTTP server during the test phase instead of calling out to an external service, that is.)

@ozh

This comment has been minimized.

Show comment
Hide comment
@ozh

ozh Sep 18, 2018

Member

Yeah, httpbin flakiness can be a pain, but usually it just works fine enough :)

Member

ozh commented Sep 18, 2018

Yeah, httpbin flakiness can be a pain, but usually it just works fine enough :)

@ozh ozh merged commit e3475da into YOURLS:master Sep 18, 2018

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@dgw dgw deleted the dgw:login-form-hooks branch Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment