New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Readme Files #2472

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
4 participants
@yakovmanshin
Copy link
Contributor

yakovmanshin commented Dec 16, 2018

I updated readme.html to switch links to HTTPS versions, add a link to installation guide for a newer version of Ubuntu, and correct grammar mistakes.

In README.md, I switched links to HTTPS versions and added minor improvements.

README.md Updates
* Switched links to HTTPS versions
* Minor updates and improvemts
@ozh

This comment has been minimized.

Copy link
Member

ozh commented Dec 16, 2018

Changing all http to https where applicable is indeed a neat fix. I'm OK with all "minor improvements", except one: you suggest changing "Sequential keyword" with "Random keyword. The thing is, "sequential" is the correct term here. Out of the box, generated keywords are sequential. With a plugin, you can make them random (or any other behavior)

@yakovmanshin

This comment has been minimized.

Copy link
Contributor

yakovmanshin commented Dec 16, 2018

I guess I’ll revert to “sequential” then.

@dgw
Copy link
Member

dgw left a comment

Just one little detail I noticed. Great overhaul, though!

Show resolved Hide resolved readme.html Outdated
@dgw

This comment has been minimized.

Copy link
Member

dgw commented Dec 16, 2018

@ozh I'd say the extra detail-tweaking commits to readme.html should be squashed out. What say you?

@LeoColomb
Copy link
Member

LeoColomb left a comment

LGTM 👍

Fixes #2464

@dgw

This comment has been minimized.

Copy link
Member

dgw commented Dec 17, 2018

@yakovmanshin Would you mind squashing (as fixup) those last two commits? Then I'll merge this when I get home. 😸

@yakovmanshin

This comment has been minimized.

Copy link
Contributor

yakovmanshin commented Dec 17, 2018

@dgw Sure, squash them.

@dgw

This comment has been minimized.

Copy link
Member

dgw commented Dec 17, 2018

@yakovmanshin When I get back tonight, will do.

readme.html Updates
* Added a link to installation guide for Ubuntu 18.04
* Updated links with HTTPS versions
* Corrected grammar mistakes
* Minor improvements
@dgw

This comment has been minimized.

Copy link
Member

dgw commented Dec 18, 2018

@yakovmanshin Did the rebase/squash, but can't push it to your branch—I get "permission denied". Perhaps "Allow edits from maintainers" needs to be enabled (see GitHub docs), and/or there's some branch restriction at play (such as GitHub not allowing me to push to your fork's default branch).

Hopefully this is as simple as checking the box to allow edits, but in case it isn't I did push the squashed history to dgw@2472-rebased so it's available for you to pull and force-push yourself.

@yakovmanshin

This comment has been minimized.

Copy link
Contributor

yakovmanshin commented Dec 18, 2018

@dgw Wow, I don’t even know how this checkbox got disabled. I enabled it, so you can try again.

@dgw dgw force-pushed the yakovmanshin:master branch from 9fd628d to 3e17759 Dec 18, 2018

@dgw

This comment has been minimized.

Copy link
Member

dgw commented Dec 18, 2018

@yakovmanshin Maybe it's disabled by default if you open a PR from a fork's default branch? Just speculating; haven't been able to find a whole lot of documentation except what I linked earlier.

Thanks for checking the box; GitHub accepted the push now, and I'll merge when Travis is happy. 👍

@yakovmanshin

This comment has been minimized.

Copy link
Contributor

yakovmanshin commented Dec 18, 2018

@dgw That’s great; thank you!

@dgw dgw merged commit 0770188 into YOURLS:master Dec 18, 2018

2 checks passed

Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment