New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pomo/pomo to 1.4.1 #2484

Merged
merged 2 commits into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@J0WI
Copy link
Contributor

J0WI commented Jan 8, 2019

@LeoColomb
Copy link
Member

LeoColomb left a comment

Thanks a lot! 👍
Just a small action requested here: you need to run includes/vendor/build-script/yourls-build.sh to remove vendor artifacts.

@J0WI

This comment has been minimized.

Copy link
Contributor Author

J0WI commented Jan 9, 2019

This break things...

LeoColomb added a commit that referenced this pull request Jan 13, 2019

@LeoColomb
Copy link
Member

LeoColomb left a comment

I will update the script to resolve that issue, and merge directly in master.
Thanks again for the PR.

@@ -38,5 +38,8 @@
"suggest": {
"ext-mbstring": "For best performance",
"ext-curl": "Required for API usage"
},
"script": {
"post-update-cmd": "./includes/vendor/build-script/yourls-build.sh includes/vendor"

This comment has been minimized.

@LeoColomb

LeoColomb Jan 13, 2019

Member

Good idea 👍

LeoColomb added a commit that referenced this pull request Jan 13, 2019

LeoColomb added a commit that referenced this pull request Jan 13, 2019

@LeoColomb LeoColomb merged commit 5bffcc5 into YOURLS:master Jan 13, 2019

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment