New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprectaed create_function with anonymous function #2486

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
3 participants
@J0WI
Copy link
Contributor

J0WI commented Jan 8, 2019

No description provided.

@ozh

This comment has been minimized.

Copy link
Member

ozh commented Jan 9, 2019

Indeed, but shouldn't this be function() use ( $message ) { echo "$message";} instead of single quotes?

@J0WI J0WI force-pushed the J0WI:anon-func branch from eacf0d5 to 0630e0e Jan 9, 2019

@J0WI

This comment has been minimized.

Copy link
Contributor Author

J0WI commented Jan 9, 2019

Fixed

@ozh

This comment has been minimized.

Copy link
Member

ozh commented Jan 10, 2019

I don't have time right now to test this (and obviously unit test results show this isnt covered) but I'm a bit concerned you're submitting one or another without seemingly testing either :) I'll test when I have some time.

@J0WI

This comment has been minimized.

Copy link
Contributor Author

J0WI commented Jan 10, 2019

The goal of this is to officially support PHP 7.2 (and maybe also 7.3) as your Docker image already does.

@ozh

This comment has been minimized.

Copy link
Member

ozh commented Jan 11, 2019

I totally get the goal and we're all for it. I'm just saying that I'm not sure which of your two commits is actually correct since you don't seem to test what you propose :)

Show resolved Hide resolved includes/functions-html.php Outdated
Show resolved Hide resolved includes/functions-html.php Outdated

@J0WI J0WI force-pushed the J0WI:anon-func branch from 0630e0e to 1121f2b Jan 13, 2019

@LeoColomb
Copy link
Member

LeoColomb left a comment

Thanks a lot @J0WI, lgtm. 👍

@ozh ozh merged commit 1013805 into YOURLS:master Jan 13, 2019

3 checks passed

Codacy/PR Quality Review Up to standards. A positive pull request.
Details
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ozh

This comment has been minimized.

Copy link
Member

ozh commented Jan 13, 2019

👍

@J0WI J0WI deleted the J0WI:anon-func branch Jan 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment