Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created SVG version of YOURLS logo #2548

Merged
merged 1 commit into from Nov 21, 2019
Merged

Created SVG version of YOURLS logo #2548

merged 1 commit into from Nov 21, 2019

Conversation

@JayHoltslander
Copy link
Contributor

JayHoltslander commented Sep 2, 2019

Old raster logo painstakingly recreated as a vector graphic.

@ozh

This comment has been minimized.

Copy link
Member

ozh commented Sep 2, 2019

Man, that's truly awesome. I guess SVG graphics are totally cross browser compatible these days? Should we keep the .png as is (instead of replacing it as your commit does) and use the .svg instead in files, eg .HTML, .MD and such?

@JayHoltslander

This comment has been minimized.

Copy link
Contributor Author

JayHoltslander commented Sep 2, 2019

@LeoColomb

This comment has been minimized.

Copy link
Member

LeoColomb commented Sep 3, 2019

maybe total replacement of the png isn't safe without checking other files first.

Indeed! That should be easy, though.

@ozh

This comment has been minimized.

Copy link
Member

ozh commented Sep 25, 2019

@JayHoltslander could you remove the first commit so we keep the .png along with the new .svg? This way we'll just use the newer file but won't break anything using the png one

@JayHoltslander

This comment has been minimized.

Copy link
Contributor Author

JayHoltslander commented Oct 16, 2019

Sorry about the slow reply. Will try to do this evening.

@dgw dgw force-pushed the JayHoltslander:master branch from 1a92413 to 22b74ce Nov 2, 2019
@dgw

This comment has been minimized.

Copy link
Member

dgw commented Nov 2, 2019

@ozh Rebased myself, since we've been waiting several weeks now. Ready to merge if you like, unless it bugs you to have the author & committer be different.

@dgw
dgw approved these changes Nov 2, 2019
@Art4
Art4 approved these changes Nov 21, 2019
@ozh ozh merged commit 792f2e5 into YOURLS:master Nov 21, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer No new issues
Details
freuds added a commit to Quotatis/YOURLS that referenced this pull request Dec 11, 2019
Add vector version of YOURLS logo (YOURLS#2548)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.