Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix composer warning about uppercase in require block #2557

Merged
merged 2 commits into from Oct 3, 2019

Conversation

@hnnweb
Copy link
Contributor

commented Oct 2, 2019

Fix composer warning about uppercase in require block

$ composer install
Deprecation warning: require.rmccue/Requests is invalid, it should not contain uppercase characters. Please use rmccue/requests instead. Make sure you fix this as Composer 2.0 will error.
Loading composer repositories with package information
Installing dependencies (including require-dev) from lock file
Nothing to install or update
Generating autoload files
Fix composer warning about uppercase in require block
@ozh
ozh approved these changes Oct 2, 2019
@ozh

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Sure. I'll let @LeoColomb say if there is potential impact to this, I'm not even sure what we really need this composer file for (should the composer lock file be updated as well? other composer include files?)

Copy link
Member

left a comment

should the composer lock file be updated as well

Indeed, the lock must be updated. 🙂

@hnnweb

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Updated the lock file. Ran composer update nothing

@hnnweb

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

It actually wrote

$ git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)

	modified:   composer.lock
	modified:   includes/vendor/autoload.php
	modified:   includes/vendor/composer/ClassLoader.php
	modified:   includes/vendor/composer/LICENSE
	modified:   includes/vendor/composer/autoload_real.php
	modified:   includes/vendor/composer/installed.json

no changes added to commit (use "git add" and/or "git commit -a")

this aswell. Want them too?

Copy link
Member

left a comment

Nope that looks good.

@LeoColomb LeoColomb changed the title Update composer.json Fix composer warning about uppercase in require block Oct 3, 2019
@LeoColomb LeoColomb merged commit 207a32e into YOURLS:master Oct 3, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.