Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim overlong client information (HTTP referrer and user-agent) #2574

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@LorenzCK
Copy link
Contributor

LorenzCK commented Nov 5, 2019

When following links from very long URLs (for instance, from mailing lists or newsletters), overlong client information fails to INSERT into the database because of the table's field lengths.
These two very simple changes trim overlong strings (maximum length as indicated in includes\functions-install.php).

@ozh

This comment has been minimized.

Copy link
Member

ozh commented Nov 6, 2019

I can't believe this hasn't been fixed decades ago. Thanks !

(This said, user agents shouldn't be at fault, unless a plugin changes default : https://github.com/YOURLS/YOURLS/blob/master/includes/functions.php#L701)

@ozh
ozh approved these changes Nov 6, 2019
@ozh ozh merged commit 16db624 into YOURLS:master Nov 6, 2019
2 checks passed
2 checks passed
Scrutinizer No new issues
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@LorenzCK

This comment has been minimized.

Copy link
Contributor Author

LorenzCK commented Nov 7, 2019

(This said, user agents shouldn't be at fault, unless a plugin changes default : https://github.com/YOURLS/YOURLS/blob/master/includes/functions.php#L701)

Didn't notice that! Anyway, better safe than sorry I guess. 😊 Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.