Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt at fixing #2603 and superseding #2545 #2625

Merged
merged 9 commits into from Mar 25, 2020
Merged

Attempt at fixing #2603 and superseding #2545 #2625

merged 9 commits into from Mar 25, 2020

Conversation

@ozh
Copy link
Member

ozh commented Mar 22, 2020

This all boils down to redirecting to $_SERVER['REQUEST_URI'] after successful login and using less $_SERVER variables ('HTTP_HOST', 'HOSTNAME', 'SERVERNAME' or whatnot)

This all boils down to redirecting to $_SERVER['REQUEST_URI'] after successful login
Copy link
Member

LeoColomb left a comment

Few comments 😄

Otherwise lgtm 👍

tests/includes/utils.php Show resolved Hide resolved
tests/includes/utils.php Outdated Show resolved Hide resolved
includes/functions.php Outdated Show resolved Hide resolved
@ozh ozh mentioned this pull request Mar 23, 2020
ozh and others added 6 commits Mar 23, 2020
- no dying
- no output if we're on cli
Co-Authored-By: Léo Colombaro <git@colombaro.fr>
Co-Authored-By: Léo Colombaro <git@colombaro.fr>
Do not rely on HOSTNAME, HTTP_HOST or whatever, just use YOURLS_SITE
@pcolmer

This comment has been minimized.

Copy link

pcolmer commented Mar 25, 2020

@ozh I've tested this on our Docker installation and it fixes the issues I was encountering. Thank you.

[skip ci] [skip scrutinizer]
@ozh

This comment has been minimized.

Copy link
Member Author

ozh commented Mar 25, 2020

Merging. Thanks @hangxingliu and @pcolmer for insightful feedbacks which has led to this PR

@ozh ozh merged commit 916377d into master Mar 25, 2020
1 check passed
1 check passed
Scrutinizer Analysis: 84 new issues, 718 updated code elements – Tests: passed
Details
@ozh ozh deleted the issue2603 branch Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.