Mojito seems to override Y.log, without maintaining the original contract #512

Closed
sdesai opened this Issue Sep 14, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@sdesai

sdesai commented Sep 14, 2012

On the client, Y.log seems to get displaced in mojito-client.client.js, and the new version doesn't seem to fire the log event fired by Y.log (when CE is present). As a result code listening for the log event is never notified.

Would it be better for Mojito to listen to the event itself to add custom behavior, instead of displacing the original implementation? If not, can we re-introduce the original behavior in the displaced version.

@caridy

This comment has been minimized.

Show comment Hide comment
@caridy

caridy Sep 14, 2012

Collaborator

Related to issue #70, we definitely need to clean this up. I wonder what is this logger doing that YUI logger doesn't. The only thing that I can see from the source is the new 'MOJITO' level. Now that node.js env is a first class citizen for YUI, YUI logger should support all the stuff we need, even when we don't have Y on a file, we should be able to require require('yui/yui-base') to get Y.log there.

Collaborator

caridy commented Sep 14, 2012

Related to issue #70, we definitely need to clean this up. I wonder what is this logger doing that YUI logger doesn't. The only thing that I can see from the source is the new 'MOJITO' level. Now that node.js env is a first class citizen for YUI, YUI logger should support all the stuff we need, even when we don't have Y on a file, we should be able to require require('yui/yui-base') to get Y.log there.

@caridy

This comment has been minimized.

Show comment Hide comment
@caridy

caridy Oct 17, 2012

Collaborator

FYI, fixed in 0.5.0pr2, and will be documented as part of 0.5.0. Y.log is the logger in mojito, no more wrapping.

Collaborator

caridy commented Oct 17, 2012

FYI, fixed in 0.5.0pr2, and will be documented as part of 0.5.0. Y.log is the logger in mojito, no more wrapping.

@rwaldura rwaldura closed this Oct 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment