Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Mojito seems to override Y.log, without maintaining the original contract #512
On the client, Y.log seems to get displaced in mojito-client.client.js, and the new version doesn't seem to fire the log event fired by Y.log (when CE is present). As a result code listening for the log event is never notified.
Would it be better for Mojito to listen to the event itself to add custom behavior, instead of displacing the original implementation? If not, can we re-introduce the original behavior in the displaced version.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
Related to issue #70, we definitely need to clean this up. I wonder what is this logger doing that YUI logger doesn't. The only thing that I can see from the source is the new 'MOJITO' level. Now that node.js env is a first class citizen for YUI, YUI logger should support all the stuff we need, even when we don't have