enable per-request tunnel url configuration #1047

Merged
merged 2 commits into from Mar 26, 2013

Conversation

Projects
None yet
2 participants
Contributor

ekashida commented Mar 26, 2013

Configured tunnelUrl must still be prefixed with tunnelPrefix.

lib/app/autoload/tunnel-client.common.js
@@ -25,6 +25,11 @@ YUI.add('mojito-tunnel-client', function(Y, NAME) {
url = this._appConfig.tunnelPrefix;
+ if (command._tunnelUrl) {
+ url = command._tunnelUrl;
+ command._tunnelUrl = null;
@caridy

caridy Mar 26, 2013

Collaborator

better to set it to undefined, which will skip the JSON.stringify process.

Collaborator

caridy commented Mar 26, 2013

done with the review!

ekashida added some commits Mar 26, 2013

enable per-request tunnel url configuration
The configurable `tunnelUrl` value will still be validated against
`tunnelPrefix`, which can be configured in application.json and defaults to
`/tunnel`.
Collaborator

caridy commented Mar 26, 2013

+1

ekashida added a commit that referenced this pull request Mar 26, 2013

Merge pull request #1047 from ekashida/tunnel-url-override-wip
enable per-request tunnel url configuration

@ekashida ekashida merged commit 02c4e7b into YahooArchive:develop Mar 26, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment