From 6abf6a58238f47f4f18072591813dd62364d0254 Mon Sep 17 00:00:00 2001 From: Lichun Zhan Date: Thu, 27 Feb 2014 14:27:24 -0800 Subject: [PATCH 1/4] allow the app starting with different port. This will fix the sd firefox issue --- examples/quickstartguide/app.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/quickstartguide/app.js b/examples/quickstartguide/app.js index 3f313087e..0878ff93e 100644 --- a/examples/quickstartguide/app.js +++ b/examples/quickstartguide/app.js @@ -14,7 +14,7 @@ var express = require('express'), app; app = express(); -app.set('port', 8666); +app.set('port', process.env.PORT || 8666); libmojito.extend(app); app.use(libmojito.middleware()); From 47045520aceb5ed1b68c5136152c79efe6b6f823 Mon Sep 17 00:00:00 2001 From: Lichun Zhan Date: Thu, 27 Feb 2014 14:28:17 -0800 Subject: [PATCH 2/4] minor clean up --- .../examples/quickstartguide/quickstartguide_descriptor.json | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tests/func/examples/quickstartguide/quickstartguide_descriptor.json b/tests/func/examples/quickstartguide/quickstartguide_descriptor.json index cf56bc718..5d4878d52 100644 --- a/tests/func/examples/quickstartguide/quickstartguide_descriptor.json +++ b/tests/func/examples/quickstartguide/quickstartguide_descriptor.json @@ -5,7 +5,7 @@ "name" : "quickstartguide", "config" :{ - "baseUrl" : "http://localhost:8666", + "baseUrl" : "http://partialsight.corp.yahoo.com:8666", "application" : { "name":"input", "path": "../../../examples/quickstartguide" @@ -21,9 +21,6 @@ "test" : "test_quickstartguide_homepage.js", "page" : "$$config.baseUrl$$" }, - { - "test" : "test_quickstartguide_homepage.js" - }, { "controller": "locator", "params": { From f11267a1401d0998891e8067625102017b3a6e73 Mon Sep 17 00:00:00 2001 From: Lichun Zhan Date: Thu, 27 Feb 2014 14:48:31 -0800 Subject: [PATCH 3/4] update arrow to latest version --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 02b426220..3c4d8a020 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ "mojito-cli": "~0.1", "node-static": ">0.6.8", "wrench": "~1.3.9", - "yahoo-arrow": "0.0.86", + "yahoo-arrow": "0.3.3", "portfinder": "0.2.1" }, "optionalDependencies": { From 4e162929700b312277affbe29f33bc2e7a95cf65 Mon Sep 17 00:00:00 2001 From: Lichun Zhan Date: Thu, 27 Feb 2014 14:56:01 -0800 Subject: [PATCH 4/4] use localhost as default --- .../examples/quickstartguide/quickstartguide_descriptor.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/func/examples/quickstartguide/quickstartguide_descriptor.json b/tests/func/examples/quickstartguide/quickstartguide_descriptor.json index 5d4878d52..5292b43cb 100644 --- a/tests/func/examples/quickstartguide/quickstartguide_descriptor.json +++ b/tests/func/examples/quickstartguide/quickstartguide_descriptor.json @@ -5,7 +5,7 @@ "name" : "quickstartguide", "config" :{ - "baseUrl" : "http://partialsight.corp.yahoo.com:8666", + "baseUrl" : "http://localhost:8666", "application" : { "name":"input", "path": "../../../examples/quickstartguide"