This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
[fix issue231] Update sys references to util references. #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scoot: just curious, do you know why/how all those commits get into the first pull request? |
|
Typically has to do with how the pull request's base branch was created. In this case it appears they didn't do a clean checkout and/or rebase sequence prior to their editing/pull request creation. |
|
👍 "sys" was renamed util in node.js 0.3.0 https://raw.github.com/joyent/node/v0.3.0/ChangeLog so it should not present any problems for ynodejs04 |
|
for some (probably unrelated) reason this fails mojito-github-pull (job 22) |
|
The two test failures in that job have been around since at least build #84 (developer guide test bugs). |
isao
pushed a commit
that referenced
this pull request
Jun 28, 2012
[fix #231] Update sys references to util references.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same edits as the automated pull request from GitHub but without all the noisy commit overhead :)