Make handlebars render mustache templates #367

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
7 participants
Collaborator

mridgway commented Aug 9, 2012

The final step of getting rid of the buggy Mu view engine is to remove it all together. In order to provide backwards compatibility with those that don't rename their template files, I propose that Handlebars render all existing mu.html templates. This works because Handlebars is a superset and implementation of the Mustache specification.

This would most likely be a phase-in for removal of mu.html support out of the box.

All regression tests pass in mojito-github-fork/82. The lone error was an invalid mustache syntax that somehow worked in Mu even though it shouldn't have. This error was fixed in the 'hbdefault' pull request.

Contributor

mojit0 commented Aug 9, 2012

+1

Michael Ridgway
Merge branch 'develop' into hb4mu
Conflicts:
	lib/app/libs/Mulib/Mu.js
	lib/app/libs/Mulib/mu/compiler.js
	lib/app/libs/Mulib/mu/parser.js
	lib/app/libs/Mulib/mu/preprocessor.js

This pull request passes (merged 3ba2beb into bb31661).

Michael Ridgway
Merge branch 'develop' of github.com:yahoo/mojito into hb4mu
Conflicts:
	lib/app/addons/view-engines/mu.server.js

This pull request passes (merged b578134 into c2a0ad9).

This pull request passes (merged 9e7590a into 32db8b5).

jenny commented Dec 4, 2012

This is a good change that we'd like to merge in. However, 0.5 introduces a number of significant changes that need to be merged into this PR first.

@ghost ghost assigned lzhan Dec 5, 2012

Contributor

lzhan commented Dec 5, 2012

0.5 is out. I will try to merge this pr.

Contributor

lzhan commented Dec 6, 2012

As Ren suggested, will revisit this after post 0.5 work is done.

Collaborator

caridy commented Dec 7, 2012

@lzhan, I will cover this as part of PR #842, no worries.

caridy added a commit to caridy/mojito that referenced this pull request Dec 7, 2012

Contributor

lzhan commented Dec 7, 2012

Great. Thanks Caridy.

Contributor

rwaldura commented Dec 14, 2012

included in #842, closing

@rwaldura rwaldura closed this Dec 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment