Bug Fix: Fixes how "mojito compile inlinecss" generates its output #418

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
6 participants

Bug Fix: Fixes how "mojito compile inlinecss" generates its output, so that each instance doesn't clobber the namespace of _mojito._cache.compiled.css.inline

Bug Fix: Fixes how "mojito compile inlinecss" generates its output, s…
…o that each instance doesn't clobber the name space

This pull request fails (merged a369270 into 94c4e79).

This pull request passes (merged a6f7fdf into 94c4e79).

Contributor

rwaldura commented Nov 2, 2012

@dferreiroval does Shaker make this PR obsolete?

Contributor

diervo commented Nov 3, 2012

@rwaldura Right now Shaker doesn't support inlining throw fies, but I have open a issue on Shaker for that. AFAIK the compiler version is kind of dummy, so I would like to implement something more robust. Anyway this compiler option it's interesting in the meanwhike. I let you know.

Contributor

diervo commented Dec 5, 2012

@rwaldura @jenny This feature will be available as part of the new set of features in Shaker3.0, which will be out in January. This means that Shaker will take of that. Other thing is if you want to keep the cssinline thing on Mojito.
Close accordingly.

Contributor

drewfish commented Dec 5, 2012

@dferreiroval that would be awesome! I'm inclined to rip out this feature once shaker has a better version. I'm not sure if we need to fix this in the mean time, since I'm not sure how many users are using mojito compile inlinecss.

I agree, if Shaker is to replace this functionality then it should be taken out of Mojito.
(It only worked for the "default" context anyways)

Collaborator

caridy commented Jan 29, 2013

This is the realm of mojito-shaker, in 3.x shaker supports this.

@caridy caridy closed this Jan 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment